2004407 - Base URI of initial about:blank is incorrectly about:blank

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Vincent Hilla [:vhilla]]

STR:

• Go to some page like https://example.com, ensure you have user activation and execute the following code
• console.log(window.open("about:blank").document.baseURI)

Expectation: https://example.com
Actual: about:blank

Cause: I expect nsWindowWatcher::OpenWindowInternal has to set openWindowInfo->mBaseUriToInheritForAboutBlank. But I'm unsure based on what conditions that should happen.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 543435

Comment 2

[Jan Jaeschke [:jjaschke]]

Vincent, could you set a severity please?

Comment 3

[Vincent Hilla [:vhilla]]

https://treeherder.mozilla.org/jobs?repo=try&revision=aca6b0e361013c46dfd8ae8f425b5e9a7ec5efd5

Comment 4

[Vincent Hilla [:vhilla]]

Attachment: Bug 2004407 - Propagate base URI to initial top level about:blank. r=hsivonen,smaug

For web compat, it suffices to have the right base URI once the initial
document is being loaded. This means we can match what would happen in
Document::Reset, instead of propagating the base URI via nsOpenWindowInfo.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Bug 543435 was reverted from Fx147. Updating the flags accordingly.

Comment 6

[Vincent Hilla [:vhilla]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8038769fab072a36796a82e5a0d6bb3dbb62321e

Comment 7

[Vincent Hilla [:vhilla]]

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=167935

Comment 8

[Vincent Hilla [:vhilla]]

Attachment: Bug 2004407 - Get policy container for initial about:blank from entry global. r=smaug!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dbad5d1e6bb4
https://hg.mozilla.org/integration/autoland/rev/59ece67605b1
Get policy container for initial about:blank from entry global. r=smaug
https://github.com/mozilla-firefox/firefox/commit/2fe2da3e4b00
https://hg.mozilla.org/integration/autoland/rev/2fd1e0d421ac
Propagate base URI to initial top level about:blank. r=smaug

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56600 for changes under testing/web-platform/tests

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dd2c2ed3134e
https://hg.mozilla.org/integration/autoland/rev/803b3a0fc050
Revert "Bug 2004407 - Propagate base URI to initial top level about:blank. r=smaug" for causing wpt failures @coep-blob-popup.https.html.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Vincent Hilla [:vhilla]]

https://html.spec.whatwg.org/#following-hyperlinks-2 step 7 chooses a navigable with "subject's node navigable" as current navigable / creator. So for link clicks, OpenWindowInternal needs to use parentDoc.

https://html.spec.whatwg.org/#window-open-steps step 2, 13 on the other hand uses the entry global's navigable as creator. So for window.open, we want to use the entry global as my patch does.

Maybe we can try to use the entry global and otherwise fall back to parentDoc. Or we accept that window.open incorrectly uses the parent instead of entry global.

Comment 14

[Vincent Hilla [:vhilla]]

(In reply to Vincent Hilla [:vhilla] from comment #13)

Maybe we can try to use the entry global and otherwise fall back to parentDoc.

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=168263

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d31e67d0063a
https://hg.mozilla.org/integration/autoland/rev/00767bd39f44
Get policy container for initial about:blank from entry global. r=smaug
https://github.com/mozilla-firefox/firefox/commit/4a7b2a969e91
https://hg.mozilla.org/integration/autoland/rev/d4561e2a7b33
Propagate base URI to initial top level about:blank. r=smaug

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56677 for changes under testing/web-platform/tests

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/00767bd39f44
https://hg.mozilla.org/mozilla-central/rev/d4561e2a7b33

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot