2004409 - Move most of the DateTimePicker actor code into common classes (to prepare for color picker)

Status: RESOLVED FIXED

(Core :: DOM: Forms, task)

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Attachment: Bug 2004409 - Split window opener logic from DateTimePicker classes r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/16894a9e464c
https://hg.mozilla.org/integration/autoland/rev/d88c660f8315
Split window opener logic from DateTimePicker classes r=emilio

Comment 3

[Cristina Horotan [:chorotan]]

Backed out for causing multiple failures

Backout link

Push with failures

Failure log browser_spectrum.js
Failure log browser_datetime_blur.js
Failure log browser_all_files_referenced.js
Failure log test_input_color_input_change_events.html
Failure log wpt

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7e7ba259147a
https://hg.mozilla.org/integration/autoland/rev/ce1cd6627122
Split window opener logic from DateTimePicker classes r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9cfe83168569
https://hg.mozilla.org/integration/autoland/rev/70972805c8c1
Revert "Bug 2004409 - Split window opener logic from DateTimePicker classes r=emilio" for causing mochitest failures

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/70972805c8c18fd401b65b84ea987687fb99ad17

Push with failures

Failure log -> ERROR - The 'prefs' key must be set in the DEFAULT section of a manifest. Fix the following manifests: dom/html/test/forms/mochitest.toml

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/datetime/browser_datetime_change_event.js | Uncaught exception in test bound test_change_event_simple

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dbe80fc5ce76
https://hg.mozilla.org/integration/autoland/rev/786df3cd8675
Split window opener logic from DateTimePicker classes r=emilio

Comment 8

[pstanciu]

Backed out for causing wpt failures @color-picker-value.html

• https://hg.mozilla.org/integration/autoland/rev/824b0d14405776c022941a89913413ad4b860864
• WPT failures
• Failure Log

@ input-element-pseudo-open.optional.html

• WPT failures
• Failure Log

@ browser_spectrum.js

• DT failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6226414a8bd0
https://hg.mozilla.org/integration/autoland/rev/4d5238300c02
Split window opener logic from DateTimePicker classes r=emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2fd8beb47a8f
https://hg.mozilla.org/integration/autoland/rev/0a488da1e966
Revert "Bug 2004409 - Split window opener logic from DateTimePicker classes r=emilio" for causing dt failures @ browser_spectrum.js

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ browser_spectrum.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0a488da1e966f05a7c1b0c71c594e9a8e28204a3

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_spectrum.js | New color is correct - Got 128, expected 127

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c51d3e49ee9e
https://hg.mozilla.org/integration/autoland/rev/cd935edd32e2
Split window opener logic from DateTimePicker classes r=emilio

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cd935edd32e2

Comment 14

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

🎉