Closed
Bug 2004455
Opened 11 months ago
Closed 11 months ago
[toolbar redesign] Add telemetry for translate action in toolbar
Categories
(Firefox for Android :: Toolbar, task)
Tracking
()
VERIFIED
FIXED
148 Branch
People
(Reporter: RJ, Assigned: RJ)
References
Details
(Whiteboard: [fxdroid][group3])
Attachments
(2 external files)
No description provided.
Updated•11 months ago
|
| Assignee | ||
Comment 1•11 months ago
|
||
Updated•11 months ago
|
Attachment #9531227 -
Attachment description: Bug 2004455 - Add translate action telemetry → WIP: Bug 2004455 - Add translate action telemetry
Updated•11 months ago
|
Attachment #9531227 -
Attachment description: WIP: Bug 2004455 - Add translate action telemetry → Bug 2004455 - Add translate action telemetry
Pushed by rmalicdem@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a722ab1909ac
https://hg.mozilla.org/integration/autoland/rev/8d9928e45739
Add translate action telemetry r=android-reviewers,Roger
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
| Assignee | ||
Comment 4•11 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D275305
Updated•11 months ago
|
Attachment #9532755 -
Flags: approval-mozilla-beta?
Comment 5•11 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: Record telemetry for toolbar shortcuts
- Code covered by automated testing: yes
- Fix verified in Nightly: no
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: Telemetry will be verified by QA
- Risk associated with taking this patch: low
- Explanation of risk level: Risk is low as this mainly adds telemetry to existing components.
- String changes made/needed: None
- Is Android affected?: no
Updated•11 months ago
|
Attachment #9532755 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•11 months ago
|
status-firefox147:
--- → fixed
Comment 7•11 months ago
•
|
||
Verified as implemented on the latest Firefox for Android Nightly 148.0a1 from 12/15, and on Beta 147.0b4, using a Samsung Galaxy S22 Ultra (Android 16).
When enabling the simple toolbar, selecting the "bookmark" shortcut, and using the shortcut, these are the generated events for Nightly:
category "customization_settings"
name "toolbar_shortcut_selection"
extra
item "bookmark"
toolbar_type "simple"
glean_timestamp "1765872127335"
category "toolbar"
name "button_tapped"
extra
glean_timestamp "1765872353135"
source "navigation_bar"
item "bookmark"
When enabling the expanded toolbar, selecting the "home" shortcut, and using the shortcut, these are the generated events for Nightly:
category "customization_settings"
name "toolbar_shortcut_selection"
extra
glean_timestamp "1765872339987"
toolbar_type "expanded"
item "homepage"
category "toolbar"
name "button_tapped"
extra
glean_timestamp "1765872353135"
source "navigation_bar"
item "home"
When enabling the simple toolbar, selecting the "translate" shortcut, and using the shortcut, these are the generated events for Nightly:
category "customization_settings"
name "toolbar_shortcut_selection"
toolbar_type "simple"
item "translate"
category "toolbar"
name "button_tapped"
source "url_bar"
item "translate"
You need to log in
before you can comment on or make changes to this bug.
Description
•