2004473 - Display Unsupported Info Message in about:translations

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P2)

Description

[Erik Nordin [:nordzilla]]

Description

The new about:translations design (internal only) includes an error message with a learn-more button when the device does not support Translations.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 2004473 - Rework about:translations scheduling r=sfoster!

This commit makes improvements to the scheduling algorithm
around reacting to user input in the source text area.

There are now 3 priorities of actions that occur.

1. Actions that happen every time an input occurs.
2. Actions that are throttled while input continually occurs.
3. Actions that are debounced and take place after input stops.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 2004473 - Add about:translations Unsupported Language Message r=sfoster!

This commit adds a new info message to the source section if the
detected language of the source text is not a language that we
support for translation.

It also removes the condition on the confidence of the detection,
allowing for more continuous feedback to the user as they're typing
now that we have a UI-facing message about language support.

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 2004473 - Remove unused learn-more button from about:translations r=sfoster!

This commit removes an unused learn-more button from the message bar
that displays when the device hardware is unsupported. The page that
we would go to is the same page as the primary learn-more link above.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2d7f9990835b
https://hg.mozilla.org/integration/autoland/rev/1c24f82ec636
Rework about:translations scheduling r=sfoster
https://github.com/mozilla-firefox/firefox/commit/78de82fecd01
https://hg.mozilla.org/integration/autoland/rev/51140ade6de2
Add about:translations Unsupported Language Message r=fluent-reviewers,desktop-theme-reviewers,bolsson,sfoster
https://github.com/mozilla-firefox/firefox/commit/9ede4df6ed09
https://hg.mozilla.org/integration/autoland/rev/970d5d0e0236
Remove unused learn-more button from about:translations r=fluent-reviewers,bolsson,sfoster

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/db8bbb5706ea
https://hg.mozilla.org/integration/autoland/rev/97cc667f93e9
Revert "Bug 2004473 - Remove unused learn-more button from about:translations r=fluent-reviewers,bolsson,sfoster"

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_MLSuggest_integration.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/97cc667f93e96ab7a3f24820356357de6c0ebf6f

Push with failures

Failure log -> browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js

Comment 7

[Erik Nordin [:nordzilla]]

This is part of a single backout that spanned multiple bugs.

In the patch stack, I increased the timeout when waiting for a mocked RemoteSettings model to download within our Translations tests, hoping that it might also help to reduce intermittent Translations test failures.

There are a few ml related tests that share our Remote Settings mocks. This test case happens to wait for the full duration of the timeout as part of the success path of the test case.

I've reverted the timeout change, and everything should hopefully be fine now.

I would one day like to either fully separate this code, or unify it in a way that ml doesn't rely on Translations under the hood, so that its more clear where the downstream consumers are.

Comment 8

[Erik Nordin [:nordzilla]]

Restoring the original timeout seems to have fixed the issue:

• https://hg.mozilla.org/try/rev/f90e8c8356a1b6f859b28cf430158700cbf43901
• https://treeherder.mozilla.org/jobs?repo=try&revision=c4b57d3456613bf4d05a01e04ce95a3679a2c8db

---

Attempting re-landing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a68790401a54
https://hg.mozilla.org/integration/autoland/rev/3e36743e6c56
Rework about:translations scheduling r=sfoster
https://github.com/mozilla-firefox/firefox/commit/8fe7035a7b9c
https://hg.mozilla.org/integration/autoland/rev/7828930caa5e
Add about:translations Unsupported Language Message r=fluent-reviewers,desktop-theme-reviewers,bolsson,sfoster
https://github.com/mozilla-firefox/firefox/commit/83183a79e99d
https://hg.mozilla.org/integration/autoland/rev/dded11dd36ac
Remove unused learn-more button from about:translations r=fluent-reviewers,bolsson,sfoster

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/3e36743e6c56
https://hg.mozilla.org/mozilla-central/rev/7828930caa5e
https://hg.mozilla.org/mozilla-central/rev/dded11dd36ac