2004736 - Handle SVG theming in moz-remote-image

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Tom Schuster]

We need to make sure SVGs that are loaded via the moz-remote-image: protocol get the correct theme (CSS's prefers-color-scheme). We might also want to handle context-fill, but that really should not be used by web content.

Comment 1

[Tom Schuster]

We need to add parameters to moz-remote-image for color-scheme, fill/stroke color/opacity and forward that to the child. The question is how we would even collect that information. It does feel somewhat unfortunate having to do that for e.g. favicons in JS.

In the child, I think we need to do something similar to nsWindowGfx::CreateIcon, where we set-up an SVGImageContext and call imgIContainer::Draw instead of imgContainer::GetFrame. I believe we also need to fake a nsISVGPaintContext, similar to this test.

Comment 2

[Tom Schuster]

Attachment: Bug 2004736 - Support colorScheme parameter for SVG in moz-remote-image:. r?tnikkel

Comment 3

[Tom Schuster]

Attachment: Bug 2004736 - Test for SVG colorScheme in moz-remote-image. r?tnikkel

Comment 4

[Tom Schuster]

I only did color-scheme for now, but support for fill-color etc. should be trivial to add.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4dff522912bd
https://hg.mozilla.org/integration/autoland/rev/d24f9a765215
Support colorScheme parameter for SVG in moz-remote-image:. r=tnikkel
https://github.com/mozilla-firefox/firefox/commit/8f1dfc652f3a
https://hg.mozilla.org/integration/autoland/rev/58ea88d2c7b9
Test for SVG colorScheme in moz-remote-image. r=tnikkel

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d24f9a765215
https://hg.mozilla.org/mozilla-central/rev/58ea88d2c7b9