2004793 - getSelectedLocale spends time sorting locales unnecessarily

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[Markus Stange [:mstange]]

Profile: https://share.firefox.dev/48FzHrj

When we call getSelectedLocale during the initialization of the pocket stories service, we spend an unnecessary amount of time building a sorted list of the supported locales, just so that we can check whether the locale returned from getCurrentLocale is one of the supported locales.

I believe we could just check getCurrentLocale's language tag against the language tags in SUPPORTED_LOCALE_ARRAY instead.

The sorting is slow because the displayLanguage and displayCountry accessors don't cache the ICU locale object, so those internal C++ objects get recreated for every comparison performed during the sort.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 2004793 - Optimize getSelectedLocale. We were doing an unnecessary sort of 120 languages, recreating ICU locale objects during every sort comparison. r=#android-reviewers

Comment 2

[Jonathan Almeida [:jonalmeida]]

Triage: adding the whiteboard label for tracking.

Adding the label because locale querying affects the pocket config which affects the homepage.

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Tooling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Jonathan Almeida [:jonalmeida]]

You think everything is tooling, BugBot.

Comment 5

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:polly, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Kaya [:kaya]]

Attachment: Bug 2004793 - Avoid recreating ICU locale objects in getSelectedLocale by checking language tags directly.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2332044db7b9
https://hg.mozilla.org/integration/autoland/rev/eccb019b8cb2
Avoid recreating ICU locale objects in getSelectedLocale by checking language tags directly. r=android-reviewers,nalexander

Comment 8

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/eccb019b8cb2