2004803 - Add initial implementation for Iterator.prototype.join

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Dan Minor [:dminor]]

Please add an initial implementation of https://tc39.es/proposal-iterator-join/, using the implementations in https://searchfox.org/firefox-main/source/js/src/builtin/Iterator.js as an example. Most of those methods are iterator helpers, but Iterator.find is an example of one that's not.

The Iterator.prototype.join method is meant to work like Array.prototype.join. That's been written in C++ and heavily optimized. We'll probably end up doing some optimizations on the Iterator version as well, but for now, let's land a version in JavaScript and add some basic tests.

Tests can be added here using a new folder called join.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 2004803 - Add implementation for Iterator.prototype.join; r=arai!

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 2004803 - Update test262-update.py; r=arai!

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 2004803 - Import Iterator Join tests; r=arai!

These are from https://github.com/tc39/test262/pull/4768 which is
currently under review. Once the tests land upstream, these can be
removed. This will be handled as part of shipping the feature when
it reaches Stage 3.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7f6b906c6833
https://hg.mozilla.org/integration/autoland/rev/6c80516c8fcb
Add implementation for Iterator.prototype.join; r=arai
https://github.com/mozilla-firefox/firefox/commit/ea836861c041
https://hg.mozilla.org/integration/autoland/rev/d13603ff7fe4
Update test262-update.py; r=arai
https://github.com/mozilla-firefox/firefox/commit/72724756a1ce
https://hg.mozilla.org/integration/autoland/rev/2f4dc55886c4
Import Iterator Join tests; r=arai

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6c80516c8fcb
https://hg.mozilla.org/mozilla-central/rev/d13603ff7fe4
https://hg.mozilla.org/mozilla-central/rev/2f4dc55886c4