2004831 - [wpt-sync] Sync PR 56582 - [focusgroup] Remove non-entry items from sequential focus navigation

Status: NEW

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 56582 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/56582
Details from upstream follow.

Jacques Newman <[e-mail]> wrote:

[focusgroup] Remove non-entry items from sequential focus navigation

Updates focus_controller to use the new utils for focusgroup.

Since each focusgroup segment is guaranteed to have just a single tab
stop, this means that focusgroup effectively removes all other elements
from sequential focus navigation.

This change updates the focus algorithm to not consider these elements
when seeking to find the next focusable item.

Bug: 40210717
Change-Id: I05d355b1161b2b89ef23f50b31c1e60100893ba7
Reviewed-on: https://chromium-review.googlesource.com/7200224
WPT-Export-Revision: fa6f1fac73749e98c7b019068016fef3bada8606

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=80da6a9daf0f8981bee86fc620c31e681637646d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 7 tests and 2 subtests

Status Summary

Firefox

OK : 7
PASS: 8
FAIL: 18

Chrome

OK : 7
PASS: 10
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/interaction/focus/focusgroup/tentative/sequential-navigation/basic-tab-behavior.html [wpt.fyi]
  • Tab enters focusgroup at first item in tree order and exits normally: FAIL (Chrome: FAIL)
  • Shift+Tab enters focusgroup at first item in tree order and exits normally: FAIL (Chrome: FAIL)
  • Arrow key navigation continues to work normally within focusgroup: FAIL (Chrome: PASS)
• /html/interaction/focus/focusgroup/tentative/sequential-navigation/dynamic-changes.html [wpt.fyi]
  • Dynamic focusgroup-entry-priority changes affect entry element selection: FAIL (Chrome: FAIL)
• /html/interaction/focus/focusgroup/tentative/sequential-navigation/focusgroup-segments.html [wpt.fyi]
  • Tab navigation through focusgroup segments - forward direction: FAIL (Chrome: FAIL)
  • Shift+Tab navigation through focusgroup segments - backward direction: FAIL (Chrome: FAIL)
  • Arrow key navigation treats opted-out elements as if they don't exist: FAIL (Chrome: PASS)
  • Complex nested opt-out creates proper focusgroup segments: FAIL (Chrome: FAIL)
• /html/interaction/focus/focusgroup/tentative/sequential-navigation/guaranteed-tab-stop-priority.html [wpt.fyi]
  • Element with focusgroup-entry-priority is selected as entry element: FAIL (Chrome: FAIL)
  • focusgroup-entry-priority works with natively focusable elements: FAIL (Chrome: FAIL)
  • Reverse navigation uses same priority algorithm: FAIL (Chrome: FAIL)
• /html/interaction/focus/focusgroup/tentative/sequential-navigation/memory-behavior.html [wpt.fyi]
  • Focusgroup with memory remembers last focused item on re-entry: FAIL (Chrome: FAIL)
  • Focusgroup with no-memory does not remember last focused item: FAIL (Chrome: FAIL)
  • Memory behavior with focusgroup segments remembers per-segment: FAIL (Chrome: FAIL)
  • Memory works correctly for first focusgroup segment: FAIL (Chrome: FAIL)
  • Last focused item is updated by arrow key navigation: FAIL (Chrome: FAIL)
• /html/interaction/focus/focusgroup/tentative/sequential-navigation/nested-focusgroups.html [wpt.fyi]
  • Forward Tab navigation through nested focusgroups: FAIL (Chrome: FAIL)
  • Reverse Shift+Tab navigation through nested focusgroups: FAIL (Chrome: FAIL)