2004905 - Some preliminary clean-ups to our theming infrastructure

Status: NEW

(Firefox :: Theme, task, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

Bug 2003921 wants to force a particular window type to have a particular theme. For now, this theme is not overridable, but it will be in the future.

It would be easy to implement in LightWeightThemeConsumer, except for the fact that there's no great way of applying the theme data without the extensions code around.

I have some clean-ups that make doing this trivial-ish, and also should be better and less confusing. Right now the startup data for a theme contains a lot of duplicated data and this cleans it up while at it.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2004905 - Clean up a bit LightweightThemeManager. r=#theme

No behavior change, this is just unused code.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2004905 - Move manifest -> lwtData conversion to LightweightThemeManager. r=#theme!,#extension-reviewers!,Gijs

No behavior change. This is in preparation to be able to pull theme
data from a built-in manifest without involving instantiating an
extension, see bug 2003921 for context.

While at it, reduce the amount of startup data we store. lwtData already
includes the light / dark styles, and experiment too, so no need to store
them separately.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9cc829db5def
https://hg.mozilla.org/integration/autoland/rev/d7d1f1a8ac11
Clean up a bit LightweightThemeManager. r=desktop-theme-reviewers,extension-reviewers,dao,rpl

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d7d1f1a8ac11

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a43d3e45ae2b
https://hg.mozilla.org/integration/autoland/rev/d37143068560
Move manifest -> lwtData conversion to LightweightThemeManager. r=Gijs,desktop-theme-reviewers,extension-reviewers,dao,robwu