2004989 - [Downloads path] Download file into the path taken from the Settings

Status: RESOLVED FIXED

(Firefox for Android :: Downloads, task)

Description

[Titouan Thibaud [:titouan]]

With Bug 2004986, the user can select the location where they want to download the new files.

In this bug, we want to use the path from the Settings for new downloads.

Comment 1

[Iorga Gabriel]

Attachment: Bug 2004989 - [Downloads path] Download file into the path taken from the Settings.

Comment 4

[Iorga Gabriel]

Attachment: Bug 2004989 - [Downloads path] Download file into the path taken from the Settings.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/70321b0885eb
https://hg.mozilla.org/integration/autoland/rev/36fbefb1ce85
[Downloads path] Download file into the path taken from the Settings. r=android-reviewers,android-addons-reviewers,tthibaud,android-l10n-reviewers,flod,robwu

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/36fbefb1ce85

Comment 7

[Titouan Thibaud [:titouan]]

For QA, here is an STR:

• Open the ThreeDot Menu > Downloads > Settings (top right icon)
• Click the "Default download location" field
• Select a folder in your local storage
• Download a file

Expected result

• The file should be downloaded successfully
• If you open in a file manager the folder you've picked, you should see the file you've just downloaded

Other things to test
1)

• From the Downloads settings, enable "Delete from Firefox Nightly and device"
• Delete the file you've downloaded in the custom folder. Wait until the "Undo" snackbar disappears
• With your file manager, make sure the file has indeed been removed

• Pick a folder
• With your file manager, delete this folder
• Open Fenix, download a file.
• Make sure it was downloaded successfully
• Open the Download settings. The "Default download location" should be set to "~/Downloads"

If you think of anything else that should be tested after this change, feel free to test it too and to share it here (it can be useful for the next bugs, where we're extending support to External Storage and some Cloud Storage provider that appear in the native Android File Picker)

Thanks a lot in advance!

Comment 8

[Mira Lobontiu (Android QA)]

Verified as implemented on the latest Firefox for Android Nightly 150.0a1 from 3/9 using an Oppo Find N2 Flip (Android 15), and a Pixel 6 (Android 16).

• The created folder for downloads in the internal storage of the device is successfully populated when downloading files.
• When "Delete from Firefox Nightly and device" is enabled, and the downloaded files are deleted, they are also deleted from the created folder.
• When the created folder is deleted, the following downloads are saved in the default folder.
• When "Delete from Firefox Nightly and device" is enabled, deleting a file from the specified location, the file is removed also from Firefox for Android.