2005077 - Baseline support for the Digital Credentials API

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, enhancement, P2)

Description

[John Schanck [:jschanck]]

Add the basic plumbing necessary for the DC API.

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 2005077 - factor promise creation out of WebAuthnHandler. r=keeler

Comment 2

[John Schanck [:jschanck]]

Attachment: Bug 2005077 - handle already-aborted signals in credentials container. r=bvandersloot

Comment 3

[John Schanck [:jschanck]]

Attachment: Bug 2005077 - stub implementation of the digital credentials API. r=bvandersloot

Comment 4

[John Schanck [:jschanck]]

Attachment: Bug 2005077 - add digital-credentials permission policies. r?tschuster,bvandersloot

Comment 5

[John Schanck [:jschanck]]

Attachment: Bug 2005077 - fix missing user activation in several DC API tests. r=bvandersloot

Comment 6

[John Schanck [:jschanck]]

Attachment: Bug 2005077 - add an option to allow scripts to run while modal is shown. r?emz

Comment 7

[John Schanck [:jschanck]]

Attachment: Bug 2005077 - add a tab modal consent prompt for DC API requests. r=bvandersloot

Comment 8

[John Schanck [:jschanck]]

Attachment: WIP: Bug 2005077 - add Digital Credential consent prompt on android.

Comment 9

[Phabricator Automation]

Comment on attachment 9533761 [details]
Bug 2005077 - add a tab modal consent prompt for DC API requests. r=bvandersloot

Revision D276911 was moved to bug 2010091. Setting attachment 9533761 [details] to obsolete.

Comment 10

[Phabricator Automation]

Comment on attachment 9534292 [details]
WIP: Bug 2005077 - add Digital Credential consent prompt on android.

Revision D277235 was moved to bug 2010093. Setting attachment 9534292 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9533760 [details]
Bug 2005077 - add an option to allow scripts to run while modal is shown. r?emz

Revision D276910 was moved to bug 2010091. Setting attachment 9533760 [details] to obsolete.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/95f2ce32aa97
https://hg.mozilla.org/integration/autoland/rev/a9ff597e3d23
factor promise creation out of WebAuthnHandler. r=keeler
https://github.com/mozilla-firefox/firefox/commit/fc750b7a7a78
https://hg.mozilla.org/integration/autoland/rev/1079ff06cc2c
handle already-aborted signals in credentials container. r=bvandersloot
https://github.com/mozilla-firefox/firefox/commit/51971caa7ab8
https://hg.mozilla.org/integration/autoland/rev/f38a6245e6da
stub implementation of the digital credentials API. r=bvandersloot,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/d3d2dc63c42a
https://hg.mozilla.org/integration/autoland/rev/6ca1179d73af
add digital-credentials permission policies. r=tschuster,bvandersloot
https://github.com/mozilla-firefox/firefox/commit/23cd7dad3b68
https://hg.mozilla.org/integration/autoland/rev/fd633cf02ac0
fix missing user activation in several DC API tests. r=bvandersloot

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57172 for changes under testing/web-platform/tests

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3f9870ac091b
https://hg.mozilla.org/integration/autoland/rev/7a966be7937e
Revert "Bug 2005077 - fix missing user activation in several DC API tests. r=bvandersloot" for causing wpt failures DONTBUILD

Comment 15

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/7a966be7937e2668eb317f9a55432e07f6ec3a65

Push with failures

Failure log -> TEST-UNEXPECTED-PASS | /credential-management/credentialscontainer-create-basics.https.html | navigator.credentials.create() aborted with custom reason - expected FAIL

Failure log -> TEST-UNEXPECTED-PASS | /credential-management/otpcredential-get-basics.https.html | Should abort request - expected FAIL

also these build bustages -> https://treeherder.mozilla.org/logviewer?job_id=543634304&repo=autoland&task=KoemxQx_SQK7AeCbpiyksQ.0&lineNumber=71682

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[John Schanck [:jschanck]]

The build bustage isn't really from my patch. I reproduced the failure locally and it's happening because my webidl bindings push SanitizerBindings.cpp into a different block of UnifiedBindings[N].cpp. It only affects the asan-fuzzing-nyx build because there are Nyx specific webidl bindings that are not included in other builds.

How should we proceed?

Comment 18

[John Schanck [:jschanck]]

I opened Bug 2010927 and attached a patch there. I also have a try run going with this stack rebased on the Codegen.py fix: https://treeherder.mozilla.org/jobs?repo=try&revision=8e0264119a82020ee53f61ff7fad89cca0fe68f6

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d0dc9e0c6fba
https://hg.mozilla.org/integration/autoland/rev/b9f86f2e9ebb
factor promise creation out of WebAuthnHandler. r=keeler
https://github.com/mozilla-firefox/firefox/commit/a095c9d9e249
https://hg.mozilla.org/integration/autoland/rev/64adcde75a01
handle already-aborted signals in credentials container. r=bvandersloot

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6db9f86f6d00
https://hg.mozilla.org/integration/autoland/rev/1e4e206a795f
Revert "Bug 2005077 - handle already-aborted signals in credentials container. r=bvandersloot" for causing build bustages on CredentialsContainer.

Comment 21

[Cosmin Sabou [:CosminS]]

Backed out for causing build bustages on CredentialsContainer.

Push with failures

Failure log

Backout link

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f483f8fd90e1
https://hg.mozilla.org/integration/autoland/rev/eafb57372690
factor promise creation out of WebAuthnHandler. r=keeler
https://github.com/mozilla-firefox/firefox/commit/fa6723c7819f
https://hg.mozilla.org/integration/autoland/rev/e6a74545f6fb
handle already-aborted signals in credentials container. r=bvandersloot
https://github.com/mozilla-firefox/firefox/commit/abb7043c32fc
https://hg.mozilla.org/integration/autoland/rev/a323a1cb5c09
stub implementation of the digital credentials API. r=bvandersloot,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/1bd3361e0cf9
https://hg.mozilla.org/integration/autoland/rev/18bdff984c31
add digital-credentials permission policies. r=tschuster,bvandersloot

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/05713bb5c544
https://hg.mozilla.org/integration/autoland/rev/ab1341b35997
Revert "Bug 2005077 - add digital-credentials permission policies. r=tschuster,bvandersloot" for causing mochitest failures on test_webauthn_get_assertion.html

Comment 24

[Cristina Horotan [:chorotan]]

Backed out for causing mochitest failures on test_webauthn_get_assertion.html

Backout link

Push with failures

Failure log

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b2c82ec628a1
https://hg.mozilla.org/integration/autoland/rev/824f54fe14f6
factor promise creation out of WebAuthnHandler. r=keeler
https://github.com/mozilla-firefox/firefox/commit/55e524ddb136
https://hg.mozilla.org/integration/autoland/rev/715f3570d74f
handle already-aborted signals in credentials container. r=bvandersloot
https://github.com/mozilla-firefox/firefox/commit/b1fff91f059d
https://hg.mozilla.org/integration/autoland/rev/be186e941903
stub implementation of the digital credentials API. r=bvandersloot,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/062c175beb1e
https://hg.mozilla.org/integration/autoland/rev/95be2637cc98
add digital-credentials permission policies. r=tschuster,bvandersloot

Comment 26

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/824f54fe14f6
https://hg.mozilla.org/mozilla-central/rev/715f3570d74f
https://hg.mozilla.org/mozilla-central/rev/be186e941903
https://hg.mozilla.org/mozilla-central/rev/95be2637cc98