Closed Bug 2005120 Opened 10 months ago Closed 10 months ago

riscv64: Use Zba `add.uw rd, rs1, zero` (aka `zext.w rd, rs1`) to simplify ZeroExtendWord

Categories

(Core :: JavaScript Engine: JIT, task, P5)

RISCV64
Unspecified
task

Tracking

()

RESOLVED FIXED
148 Branch
Tracking Status
firefox148 --- fixed

People

(Reporter: csmantle, Assigned: csmantle)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Once Bug 2003218 lands, we will have proper feature detection on RV64 and simulator support for Zba, Zbb and Zbs extensions. Then, we could use zext.w (^1) to simplify ZeroExtendWord (^2).

Depends on: 2003218
Hardware: Unspecified → RISCV64
Summary: riscv64: Use Zba `add.uw rd, rs1, zero` (aka `zext.w rd, rs1`) to simplify → riscv64: Use Zba `add.uw rd, rs1, zero` (aka `zext.w rd, rs1`) to simplify ZeroExtendWord
Blocks: sm-riscv64
Attachment #9532962 - Attachment description: WIP: Bug 2005120 - [riscv64] Simplify MacroAssemblerRiscv64Compat::ZeroExtendWord with zext.w from Zba extension. r=#spidermonkey-reviewers,m_kato → WIP: Bug 2005120 - [riscv64] Part 1: Simplify MacroAssemblerRiscv64Compat::ZeroExtendWord with zext.w from Zba extension. r=#spidermonkey-reviewers,m_kato

Existing functions uses an underscore to replace the dots in instruction
mnemonics to form a valid C identifier. This patch renames newly-added
functions to match this convention.

Assignee: nobody → webmaster
Attachment #9532962 - Attachment description: WIP: Bug 2005120 - [riscv64] Part 1: Simplify MacroAssemblerRiscv64Compat::ZeroExtendWord with zext.w from Zba extension. r=#spidermonkey-reviewers,m_kato → Bug 2005120 - [riscv64] Part 1: Simplify MacroAssemblerRiscv64Compat::ZeroExtendWord with zext.w from Zba extension. r=#spidermonkey-reviewers,m_kato
Status: NEW → ASSIGNED
Attachment #9532963 - Attachment description: WIP: Bug 2005120 - [riscv64] Part 2: (Drive-by) Rename Zb* assembler functions to existing naming convention. r=#spidermonkey-reviewers,m_kato → Bug 2005120 - [riscv64] Part 2: (Drive-by) Rename Zb* assembler functions to existing naming convention. r=#spidermonkey-reviewers,m_kato
Severity: -- → N/A
Priority: -- → P5
Pushed by iireland@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8839e907e314 https://hg.mozilla.org/integration/autoland/rev/2609990b8dc1 [riscv64] Part 1: Simplify MacroAssemblerRiscv64Compat::ZeroExtendWord with zext.w from Zba extension. r=m_kato,spidermonkey-reviewers,iain https://github.com/mozilla-firefox/firefox/commit/864016ce6169 https://hg.mozilla.org/integration/autoland/rev/f4776f7c82ef [riscv64] Part 2: (Drive-by) Rename Zb* assembler functions to existing naming convention. r=m_kato,spidermonkey-reviewers,iain
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
QA Whiteboard: [qa-triage-done-c149/b148]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: