2005214 - Fix position-area default self-alignment for different writing modes

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect)

Description

[Jonathan Watt [:jwatt]]

I've been going over creating tests for bug 2004161, looking at the existing WPT tests, and talking to jfkthame. Seems like there's still work to do. One test that should pass is:

https://searchfox.org/firefox-main/source/testing/web-platform/tests/css/css-anchor-position/position-area-align-justify-wm-dir.html

Doing that will presumably fix bug 2003542.

Comment 1

[Jonathan Kew [:jfkthame]]

I have a patch that makes all of position-area-align-justify-wm-dir.html pass locally; will post it after a bit more cleanup and adding some extra testcases.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 2005214 - patch 2 - Remove failure annotations, and add variants with sideways-lr writing mode to position-area-align-justify-wm-dir.html. r=#layout

sideways-lr is mostly like vertical-lr but has the opposite inline direction,
so I think it's important to include test coverage for this mode as well.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 2005214 - patch 1 - Fix PositionAreaKeyword::to_self_alignment() to resolve correctly for the containing block's writing mode. r=#layout

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b9daf63e7c7b
https://hg.mozilla.org/integration/autoland/rev/ed9b6344ed82
patch 1 - Fix PositionAreaKeyword::to_self_alignment() to resolve correctly for the containing block's writing mode. r=layout-reviewers,firefox-style-system-reviewers,jwatt,emilio
https://github.com/mozilla-firefox/firefox/commit/5c64bd0e8e22
https://hg.mozilla.org/integration/autoland/rev/6287fb1e2110
patch 2 - Remove failure annotations, and add variants with sideways-lr writing mode to position-area-align-justify-wm-dir.html. r=layout-reviewers,emilio,jwatt

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56637 for changes under testing/web-platform/tests

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ed9b6344ed82
https://hg.mozilla.org/mozilla-central/rev/6287fb1e2110

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 9532085 [details]
Bug 2005214 - patch 1 - Fix PositionAreaKeyword::to_self_alignment() to resolve correctly for the containing block's writing mode. r=#layout

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Needed for our Anchor Positioning release in v147.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 2004161
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixes known broken tests websites.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 9532084 [details]
Bug 2005214 - patch 2 - Remove failure annotations, and add variants with sideways-lr writing mode to position-area-align-justify-wm-dir.html. r=#layout

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Tests for the previous patch, which is needed for our Anchor Positioning release in v147.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 2004161
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): tests
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9532084 [details]
Bug 2005214 - patch 2 - Remove failure annotations, and add variants with sideways-lr writing mode to position-area-align-justify-wm-dir.html. r=#layout

Approved for 147.0b3.

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/85cdf4554a3e
https://hg.mozilla.org/releases/mozilla-beta/rev/c277d5abb8a0
https://github.com/mozilla-firefox/firefox/commit/f3fb8989d344
https://hg.mozilla.org/releases/mozilla-beta/rev/772a64f949cc

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by foolip