2005275 - NS_IsMainThread assert when logging into notion.so on a debug build.

Status: NEW

(Core :: Networking, defect, P2)

Description

[Emilio Cobos Álvarez [:emilio]]

Thread 143 (Thread 0x7f8997f7d6c0 (LWP 358348) "StreamTrans #1"):
#0  __syscall_cancel_arch () at ../sysdeps/unix/sysv/linux/x86_64/syscall_cancel.S:56
#1  0x00007f89bf89316c in __internal_syscall_cancel (a1=a1@entry=0, a2=a2@entry=0, a3=a3@entry=140228981438688, a4=a4@entry=140228981438688, a5=a5@entry=0, a6=a6@entry=0, nr=230) at cancellation.c:49
#2  0x00007f89bf8e3bd2 in __GI___clock_nanosleep (clock_id=<optimized out>, clock_id@entry=0, flags=flags@entry=0, req=req@entry=0x7f899aa038e0, rem=rem@entry=0x7f899aa038e0) at ../sysdeps/unix/sysv/linux/clock_nanosleep.c:48
#3  0x00007f89bf8efc57 in __GI___nanosleep (req=req@entry=0x7f899aa038e0, rem=rem@entry=0x7f899aa038e0) at ../sysdeps/unix/sysv/linux/nanosleep.c:25
#4  0x00007f89bf90229e in __sleep (seconds=0) at ../sysdeps/posix/sleep.c:55
#5  0x00007f89ac618390 in common_crap_handler (signum=11, aFirstFramePC=<optimized out>) at /home/emilio/src/moz/firefox-2/toolkit/xre/nsSigHandlers.cpp:105
#6  0x00007f89ac61847d in ah_crap_handler (signum=0) at /home/emilio/src/moz/firefox-2/toolkit/xre/nsSigHandlers.cpp:113
#7  0x00007f89ac5e8148 in nsProfileLock::FatalSignalHandler (signo=11, info=0x7f899aa03bf0, context=0x7f899aa03ac0) at /home/emilio/src/moz/firefox-2/toolkit/profile/nsProfileLock.cpp:186
#8  0x00007f89add4aa10 in WasmTrapHandler (signum=11, info=0x7f899aa03bf0, context=0x7f899aa03ac0) at /home/emilio/src/moz/firefox-2/js/src/wasm/WasmSignalHandlers.cpp:796
#9  0x00007f89bf83e4d0 in <signal handler called> () at /usr/lib/libc.so.6
#10 0x00007f89a591aea3 in MOZ_CrashSequence (aAddress=0x0, aLine=287) at /home/emilio/src/moz/firefox-2/obj-debug/dist/include/mozilla/Assertions.h:237
#11 mozilla::net::DictionaryCacheEntry::AccumulateHash (this=0x7f897a66ae40, aBuf=0x7f895ed83000 "\"use strict\";(globalThis.webpackChunknotion_next=globalThis.webpackChunknotion_next||[]).push([[99054],{34026:(t,e,o)=>{o.d(e,{Hs:()=>B,B$:()=>F,m:()=>L,x1:()=>K,RQ:()=>R,RZ:()=>z,H2:()=>V,IU:()=>P,Ms"..., aCount=80442) at /home/emilio/src/moz/firefox-2/netwerk/cache2/Dictionary.cpp:287
#12 0x00007f89a58e356b in mozilla::net::CacheFileOutputStream::Write (this=0x7f897fa8ba50, aBuf=0x7f895ed83000 "\"use strict\";(globalThis.webpackChunknotion_next=globalThis.webpackChunknotion_next||[]).push([[99054],{34026:(t,e,o)=>{o.d(e,{Hs:()=>B,B$:()=>F,m:()=>L,x1:()=>K,RQ:()=>R,RZ:()=>z,H2:()=>V,IU:()=>P,Ms"..., aCount=80442, _retval=0x7f8997f7bf98) at /home/emilio/src/moz/firefox-2/netwerk/cache2/CacheFileOutputStream.cpp:133
#13 0x00007f89a51b386e in nsInputStreamTee::TeeSegment (this=<optimized out>, aBuf=0x7f895ed83000 "\"use strict\";(globalThis.webpackChunknotion_next=globalThis.webpackChunknotion_next||[]).push([[99054],{34026:(t,e,o)=>{o.d(e,{Hs:()=>B,B$:()=>F,m:()=>L,x1:()=>K,RQ:()=>R,RZ:()=>z,H2:()=>V,IU:()=>P,Ms"..., aCount=80442) at /home/emilio/src/moz/firefox-2/xpcom/io/nsInputStreamTee.cpp:163
#14 0x00007f89a51d2ef9 in nsStringInputStream::ReadSegments (this=0x7f895e92f2e0, aWriter=0x7f89a51b3a10 <nsInputStreamTee::WriteSegmentFun(nsIInputStream*, void*, char const*, unsigned int, unsigned int, unsigned int*)>, aClosure=0x7f89784651a0, aCount=80442, aResult=0x7f8997f7c04c) at /home/emilio/src/moz/firefox-2/xpcom/io/nsStringStream.cpp:313
#15 0x00007f89a9236185 in mozilla::dom::FetchDriver::OnDataAvailable (this=0x7f8976dccc10, aRequest=<optimized out>, aInputStream=0x7f89784651a0, aOffset=<optimized out>, aCount=80442) at /home/emilio/src/moz/firefox-2/dom/fetch/FetchDriver.cpp:1534
#16 0x00007f89a5aa7de6 in nsCORSListenerProxy::OnDataAvailable (this=<optimized out>, aRequest=0x7f8969864c50, aInputStream=0x7f89784651a0, aOffset=0, aCount=80442) at /home/emilio/src/moz/firefox-2/netwerk/protocol/http/nsCORSListenerProxy.cpp:859
#17 0x00007f89a5539c61 in mozilla::net::nsStreamListenerTee::OnDataAvailable (this=0x7f895c7e2470, request=0x7f8969864c50, input=<optimized out>, offset=0, count=80442) at /home/emilio/src/moz/firefox-2/netwerk/base/nsStreamListenerTee.cpp:93
#18 0x00007f89a586f6cb in mozilla::net::nsHTTPCompressConv::do_OnDataAvailable (this=this@entry=0x7f8978faefc0, request=0x7f8969864c50, offset=0, buffer=buffer@entry=0x7f895ed83000 "\"use strict\";(globalThis.webpackChunknotion_next=globalThis.webpackChunknotion_next||[]).push([[99054],{34026:(t,e,o)=>{o.d(e,{Hs:()=>B,B$:()=>F,m:()=>L,x1:()=>K,RQ:()=>R,RZ:()=>z,H2:()=>V,IU:()=>P,Ms"..., count=80442) at /home/emilio/src/moz/firefox-2/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:945
#19 0x00007f89a586f452 in mozilla::net::nsHTTPCompressConv::ZstdHandler (stream=<optimized out>, closure=0x7f8978faefc0, dataIn=<optimized out>, aAvail=20960, countRead=0x7f8997f7c2cc) at /home/emilio/src/moz/firefox-2/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:575
#20 0x00007f89a51c9ccd in nsPipeInputStream::ReadSegments (this=0x7f8969d504c0, aWriter=0x7f89a586f320 <mozilla::net::nsHTTPCompressConv::ZstdHandler(nsIInputStream*, void*, char const*, unsigned int, unsigned int, unsigned int*)>, aClosure=0x7f8978faefc0, aCount=20960, aReadCount=0x7f8997f7c350) at /home/emilio/src/moz/firefox-2/xpcom/io/nsPipe3.cpp:1386
#21 0x00007f89a586fe79 in mozilla::net::nsHTTPCompressConv::OnDataAvailable (this=0x7f8978faefc0, request=0x7f8969864c50, iStr=0x7f8969d504c0, aSourceOffset=0, aCount=20960) at /home/emilio/src/moz/firefox-2/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:857
#22 0x00007f89a5af5d02 in mozilla::net::nsHttpChannel::OnDataAvailable (this=0x7f8969864c00, request=<optimized out>, input=0x7f8969d504c0, offset=<optimized out>, count=20960) at /home/emilio/src/moz/firefox-2/netwerk/protocol/http/nsHttpChannel.cpp:10511
#23 0x00007f89a54ca213 in nsInputStreamPump::OnStateTransfer (this=this@entry=0x7f89584fc7a0) at /home/emilio/src/moz/firefox-2/netwerk/base/nsInputStreamPump.cpp:611
#24 0x00007f89a54c98e8 in nsInputStreamPump::OnInputStreamReady (this=0x7f89584fc7a0, stream=<optimized out>) at /home/emilio/src/moz/firefox-2/netwerk/base/nsInputStreamPump.cpp:432
#25 0x00007f89a54cac2d in non-virtual thunk to nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) () at /home/emilio/src/moz/firefox-2/netwerk/base/nsInputStreamPump.cpp:705
#26 0x00007f89a51dab70 in CallbackHolder::CallbackHolder(nsIAsyncInputStream*, nsIInputStreamCallback*, unsigned int, nsIEventTarget*)::{lambda()#1}::operator()() const (this=<optimized out>) at /home/emilio/src/moz/firefox-2/xpcom/io/nsPipe3.cpp:73
#27 NS_NewCancelableRunnableFunction<CallbackHolder::CallbackHolder(nsIAsyncInputStream*, nsIInputStreamCallback*, unsigned int, nsIEventTarget*)::{lambda()#1}>(char const*, CallbackHolder::CallbackHolder(nsIAsyncInputStream*, nsIInputStreamCallback*, unsigned int, nsIEventTarget*)::{lambda()#1}&&)::FuncCancelableRunnable::Run() (this=<optimized out>) at /home/emilio/src/moz/firefox-2/obj-debug/dist/include/nsThreadUtils.h:637
#28 0x00007f89a521e358 in mozilla::TaskQueue::Runner::Run (this=0x7f895c7dcb80) at /home/emilio/src/moz/firefox-2/xpcom/threads/TaskQueue.cpp:263
#29 0x00007f89a524adaf in nsThreadPool::Run (this=0x7f899b2a96d0) at /home/emilio/src/moz/firefox-2/xpcom/threads/nsThreadPool.cpp:441
#30 0x00007f89a52424d5 in nsThread::ProcessNextEvent (this=0x7f899b1f8c40, aMayWait=<optimized out>, aResult=0x7f8997f7ca4f) at /home/emilio/src/moz/firefox-2/xpcom/threads/nsThread.cpp:1158
#31 0x00007f89a52482e0 in NS_ProcessNextEvent (aThread=0x7f89bfa0a780 <_IO_stdfile_2_lock>, aThread@entry=0x7f899b1f8c40, aMayWait=false) at /home/emilio/src/moz/firefox-2/xpcom/threads/nsThreadUtils.cpp:461
#32 0x00007f89a5e58c97 in mozilla::ipc::MessagePumpForNonMainThreads::Run (this=0x7f899b13ad40, aDelegate=0x7f8997f7cb10) at /home/emilio/src/moz/firefox-2/ipc/glue/MessagePump.cpp:299
#33 0x00007f89a5d96e12 in MessageLoop::RunHandler (this=0x7f89bfa0a780 <_IO_stdfile_2_lock>) at /home/emilio/src/moz/firefox-2/ipc/chromium/src/base/message_loop.cc:361
#34 MessageLoop::Run (this=0x7f89bfa0a780 <_IO_stdfile_2_lock>) at /home/emilio/src/moz/firefox-2/ipc/chromium/src/base/message_loop.cc:343
#35 0x00007f89a523e23f in nsThread::ThreadFunc (aArg=0x7f8997c63160) at /home/emilio/src/moz/firefox-2/xpcom/threads/nsThread.cpp:373
#36 0x00007f89bff3a0dd in _pt_root (arg=arg@entry=0x7f899b269ca0) at /home/emilio/src/moz/firefox-2/nsprpub/pr/src/pthreads/ptthread.c:191
#37 0x000055b89f2ce34d in set_alt_signal_stack_and_start (params=<optimized out>) at /home/emilio/src/moz/firefox-2/mozglue/interposers/pthread_create_interposer.cpp:81
#38 0x00007f89bf89698b in start_thread (arg=<optimized out>) at pthread_create.c:448
#39 0x00007f89bf91a9cc in __GI___clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78

Randell, this seems relatively new code, mind taking a look? I hit this while debugging bug 1943358.

Comment 1

[Valentin Gosu [:valentin]]

I can still reproduce this after setting network.http.dictionaries.enable to true.

Comment 2

[Valentin Gosu [:valentin]]

Randell, feel free to comandeer https://phabricator.services.mozilla.com/D284232
I think the most important part of this bug is turning the notion login flow that uses dictionaries into a WPT.

Comment 3

[Valentin Gosu [:valentin]]

Attachment: WIP: Bug 2005275 - Add mutex for dictionary hash computation off-main-thread r=jesup

Comment 4

[Valentin Gosu [:valentin]]

Randell, I went to check if this still happens. I think the code changed a bit, so it probably doesn't, but I did hit this assertion: mozilla::net::HttpBaseChannel::DoApplyContentConversionsInternal

Unfortunately it only happened once, on a dev build, and I wasn't able to get to it again.
Could you check if you're able to reproduce it? (new notion account, clicked on a few of the sections after going through the intro, maybe a navigation or refresh is necessary)