Closed Bug 2005294 Opened 11 months ago Closed 10 months ago

Update wgpu to upstream 3f02781b (2025-12-16)

Categories

(Core :: Graphics: WebGPU, task, P1)

task

Tracking

()

RESOLVED FIXED
148 Branch
Tracking Status
firefox148 --- fixed

People

(Reporter: jimb, Assigned: jimb)

References

(Blocks 1 open bug)

Details

Attachments

(3 external files)

What it says on the tin.

Assignee: nobody → jimb
Blocks: 2000823
Blocks: 2002460
  • Update wgpu crates to trunk commit 500e2bae.

  • Adapt to new DontCare variant in wgc::command::LoadOp. In
    generated C++ bindings for wgpu-types, substitute our own definition
    of WGPULoadOpDontCare, since we don't use this and cbindgen can't
    create correct C++ for zero-sized types.

  • Include subgroup_min_size and subgroup_max_size in
    AdapterInformation struct.

  • Adapt to upstream terminology change: "push constants" are now
    "immediate data". Delete unused function
    wgpu_render_bundle_set_push_constants.

  • Delete our VkImageHolder type, and use wgpu_hal::vulkan's
    very nice TextureMemory enum instead.

  • Update vendored ron to 0.12.0. Delta audit is already present in
    supply-chain/audits.toml. Update webrender to use this as well.

  • Vendor new ron dependency typeid 1.0.3. This is a very small crate.
    Trust entry is already present in supply-chain/audits.toml.

No longer blocks: 1997866

This update introduces new CTS failures in:

webgpu:shader,validation,const_assert,const_assert:constant_expression_logical_or_no_assert:*

The regressing upstream commit is wgpu#7339:

commit 119b4efada475f95507f8f577bf1abfe3d529fd0 (HEAD, andyleiserson/trunk, andyleiserson/HEAD)
Author: Andy Leiserson <aleiserson@mozilla.com>
Date:   Wed Nov 19 17:06:49 2025 -0800
    [naga wgsl-in] Short-circuiting of && and || operators (#7339)
    
    Addresses parts of #4394 and #6302
Attachment #9532252 - Attachment description: Bug 2005294: Update wgpu to upstream 500e2bae (2025-12-09) r=#webgpu-reviewers! → Bug 2005294: Update wgpu to upstream 3f02781b (2025-12-16) r=#webgpu-reviewers!
Summary: Update wgpu to upstream 500e2bae (2025-12-09) → Update wgpu to upstream 3f02781b (2025-12-16)
Blocks: 1997866
Blocks: 2000441
No longer blocks: 1997866

Build failures on macOS are due to change in return value of wgpu_hal::metal::Device::raw_device.
new try push [edit: cancelled due to mistake in fix]

My macOS fix had a careless mistake.
new try push

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch

Accidentally closed - only landed the first two of three patches

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Priority: -- → P1
Pushed by jblandy@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7bc462c09b48 https://hg.mozilla.org/integration/autoland/rev/135e1cd42789 Update wgpu to upstream 3f02781b (2025-12-16) r=webgpu-reviewers,supply-chain-reviewers,nical,aleiserson
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5ae1543dc98a https://hg.mozilla.org/integration/autoland/rev/974a1c3d2158 Revert "Bug 2005294: Update wgpu to upstream 3f02781b (2025-12-16) r=webgpu-reviewers,supply-chain-reviewers,nical,aleiserson" for causing wrench failures

Backed out for causing wrench failures

Flags: needinfo?(jimb)

Fixed WebRender's Cargo.lock, re-submitted for landing.

Flags: needinfo?(jimb)
Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/91f63d6bae16 https://hg.mozilla.org/mozilla-central/rev/96c4d9e3c03e Update wgpu to upstream 3f02781b (2025-12-16) r=webgpu-reviewers,supply-chain-reviewers,nical,aleiserson
Status: REOPENED → RESOLVED
Closed: 11 months ago → 10 months ago
Resolution: --- → FIXED
QA Whiteboard: [qa-triage-done-c149/b148]
Blocks: 2008460
Regressions: 2011999
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: