2005453 - [wpt-sync] Sync PR 56674 - Compute gradient stop colors at computed value time if necessary

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 56674 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/56674
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Compute gradient stop colors at computed value time if necessary

When working on this CL, I noticed we do not resolve computed values in
gradients which are wrapped in other values like image-set() and
cross-fade(). As a consequence of that, the added handling for
kConstantGradientClass is currently not exercised as it is only used for
solid colors inside cross-fade().

Resolving computed values in image-set()/cross-fade() will be done in
other CLs.

Bug: 465006290
Change-Id: I50bf0c14eee5612dd805a48741ac9a25c3c45105
Reviewed-on: https://chromium-review.googlesource.com/7245532
WPT-Export-Revision: 9c3396c69b684c02e447906259f10a8be5dc096d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=be33effc5490608432853cc3b7ea01603d3083eb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 21 tests and 2 subtests

Status Summary

Firefox

OK : 1[GitHub] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS : 16
FAIL : 1[GitHub] 72[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/tree-counting/calc-sibling-function-in-shadow-dom.html [wpt.fyi]
  • Host children have sibling-index() and sibling-count() based on the DOM tree order: FAIL
• /css/css-values/tree-counting/calc-sibling-function-parsing.html [wpt.fyi]
  • e.style['left'] = "calc(1px * sibling-index())" should set the property value: FAIL
  • e.style['left'] = "calc(1px * sibling-index( ))" should set the property value: FAIL
  • e.style['z-index'] = "sibling-index()" should set the property value: FAIL
  • e.style['left'] = "calc(1px * sibling-count())" should set the property value: FAIL
  • e.style['left'] = "calc(1px * sibling-count( ))" should set the property value: FAIL
  • e.style['z-index'] = "sibling-count()" should set the property value: FAIL
• /css/css-values/tree-counting/calc-sibling-function.html [wpt.fyi]
  • basic sibling-index() test: FAIL
  • basic sibling-count() test: FAIL
  • sibling-index() in calc() with percentage: FAIL
  • sibling-count() on pseudo-element: FAIL
  • sibling-index() on root: FAIL
  • sibling-count() on root: FAIL
• /css/css-values/tree-counting/sibling-function-container-query-invalidation.html [wpt.fyi]
  • sibling-index() in @container width query matching after removal: FAIL
  • sibling-count() in @container width query matching after removal: FAIL
  • sibling-index() in @container style() query matching after removal: FAIL
  • sibling-count() in @container style() query matching after removal: FAIL
• /css/css-values/tree-counting/sibling-function-container-query.html [wpt.fyi]
  • sibling-index() in @container width query: FAIL
  • sibling-count() in @container width query: FAIL
  • sibling-index() in @container style() query: FAIL
  • sibling-count() in @container style() query: FAIL
• /css/css-values/tree-counting/sibling-function-descriptors.tentative.html [wpt.fyi]
  • sibling-index() should not be allowed in @font-face descriptors: FAIL
  • sibling-count() should not be allowed in @font-face descriptors: FAIL
  • sibling-index() should not be allowed in @font-feature-values descriptors: FAIL
  • sibling-count() should not be allowed in @font-feature-values descriptors: FAIL
• /css/css-values/tree-counting/sibling-function-invalidation.html [wpt.fyi]
  • Initially 6th sibling: FAIL
  • 5th sibling after removal: FAIL
  • Initially 6 siblings: FAIL
  • 5 siblings after removal: FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-font-style-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-font-variation-settings-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-font-weight-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-length-value-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 2 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-palette-mix-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 4 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-percent-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-registered-properties-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for --time: FAIL
  • Initially, the sibling-index() is 3 for --angle: FAIL
  • Initially, the sibling-index() is 3 for --resolution: FAIL
  • Initially, the sibling-index() is 3 for --percentage: FAIL
  • Initially, the sibling-index() is 3 for --number: FAIL
  • Initially, the sibling-index() is 3 for --integer: FAIL
  • Initially, the sibling-index() is 3 for --length: FAIL
  • Initially, the sibling-index() is 3 for --length-percentage: FAIL
  • Initially, the sibling-index() is 3 for --color: FAIL
  • Initially, the sibling-index() is 3 for --list: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --time: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --angle: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --resolution: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --percentage: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --number: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --integer: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --length: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --length-percentage: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --color: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index() for --list: FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-rotate-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-scale-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-transform-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-keyframe-value-dynamic.html [wpt.fyi]
  • Initially, the sibling-index() is 3 for #target: FAIL
  • Removing a preceding sibling of #target reduces the sibling-index(): FAIL
• /css/css-values/tree-counting/sibling-index-linear-gradient-gcs.html [wpt.fyi]
  • Check that sibling-index() is resolved in serialization of computed value of linear-gradient(): FAIL (Safari: FAIL)
• /css/css-values/tree-counting/tree-scoped-sibling-function.html [wpt.fyi]
  • sibling-index() and sibling-count() evaluates to 0 from outer tree with ::part: FAIL
  • sibling-index() and sibling-count() evaluate as normal from inner tree: FAIL

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f356326a4784
https://hg.mozilla.org/integration/autoland/rev/2b9767fde33a
[wpt PR 56674] - Compute gradient stop colors at computed value time if necessary, a=testonly
https://github.com/mozilla-firefox/firefox/commit/01054642fe59
https://hg.mozilla.org/integration/autoland/rev/654f9a1ae52d
[wpt PR 56674] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2b9767fde33a
https://hg.mozilla.org/mozilla-central/rev/654f9a1ae52d