2005469 - Fedora GCC 15.x aarch64 builds crashes at nsHtml5Tokenizer::StateLoopLineColALU (Stub)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=2420679

Fedora GCC aarch64 uses stub nsHtml5Tokenizer::StateLoopLineColALU () which crashes.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1499684

:hsivonen, since you are the author of the regressor, bug 1499684, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Looks like GCC 15.0 (at least) doesn't define

__LITTLE_ENDIAN__ 

used at:

https://searchfox.org/firefox-main/rev/04cf27582307a9c351e991c740828d54cf786b76/parser/htmlaccel/htmlaccelEnabled.h#31

#elif defined(__aarch64__) && defined(__LITTLE_ENDIAN__)
#  define MOZ_MAY_HAVE_HTMLACCEL 1
  return true;

$ echo | g++ -dM -E -x c++ - | grep "LITTLE"
#define __ORDER_LITTLE_ENDIAN__ 1234
#define __FLOAT_WORD_ORDER__ __ORDER_LITTLE_ENDIAN__
#define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__

$ echo | clang++ -dM -E -x c++ - | grep "LITTLE"
#define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
#define __LITTLE_ENDIAN__ 1
#define __ORDER_LITTLE_ENDIAN__ 1234

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 2005469 Use __ORDER_LITTLE_ENDIAN__ instead of __LITTLE_ENDIAN__ r?glandium

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #1)

Also, could you set the severity field?

I'm not sure about the rules, but I gather this is S3, since this isn't a tier-1 config, despite the effect for that config being very severe.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Looks like whole sources are polluted by __LITTLE_ENDIAN__ define. As it's clang only - shall we define it on configure if building with GCC then?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/213b0b9261a6
https://hg.mozilla.org/integration/autoland/rev/536eb2dc686a
Use __ORDER_LITTLE_ENDIAN__ instead of __LITTLE_ENDIAN__ r=sergesanspaille,hsivonen

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/536eb2dc686a

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox147 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9532315 [details]
Bug 2005469 Use ORDER_LITTLE_ENDIAN instead of LITTLE_ENDIAN r?glandium

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Browser crashes aarch64
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Build fix - use correct byte order.
• String changes made/needed:
• Is Android affected?: Yes

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9532315 [details]
Bug 2005469 Use ORDER_LITTLE_ENDIAN instead of LITTLE_ENDIAN r?glandium

Approved for 147.0b5.

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/22d4b7749115
https://hg.mozilla.org/releases/mozilla-beta/rev/97f04829ca0f

Comment 12

[Dianna Smith [:diannaS]]

:stransky is this something you want to uplift for the 146.0.1 dot release?

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9532315 [details]
Bug 2005469 Use ORDER_LITTLE_ENDIAN instead of LITTLE_ENDIAN r?glandium

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Crashes on aarch64.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): aarch64/gcc build fix, use correct endian there.
• String changes made/needed:
• Is Android affected?: Yes

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9532315 [details]
Bug 2005469 Use ORDER_LITTLE_ENDIAN instead of LITTLE_ENDIAN r?glandium

Approved for 146.0.1 dot release

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9064a9228a5b
https://hg.mozilla.org/releases/mozilla-release/rev/c034066c88d9