2005482 - Constrain day before calling CreateDateFromCodes with overflow=reject for Hebrew calendar

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect, P1)

Description

[André Bargull [:anba]]

New test262 tests added in bug 2005286 revealed a bug in CreateDateFrom for the Hebrew calendar:

• When given an ordinal month, we first call CreateDateFromCodes with the ordinal month replaced by a month code. If the resolved date has the same ordinal month as the input month, we return that date. Otherwise we try to adjust for leap years.
• CreateDateFromCodes has an early check for invalid day values. This can result in rejecting valid inputs:
  • For example when month = 10 and day = 30 and the input year is a leap year. This should resolve to monthCode = M09 and day = 30. We first try month code "M10", but since "M10" can have at most 29 days, the early day values check in CreateDateFromCodes throws a RangeError.

To fix this bug, we need to constrain the days value before calling CreateDateFromCodes and later check if input day fits into the resolved month.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 2005482: Constrain day before calling CreateDateFromCodes with overflow=reject for Hebrew calendar. r=#spidermonkey-reviewers!

Constrain the input day before calling CreateDateFromCodes when
overflow=reject to avoid incorrectly rejecting dates. When the day was
constrained, handle overflow=reject through an explicit check using
CalendarDaysInMonth.

This case is specific to the Hebrew calendar and can't happen for Chinese/Dangi
calendars, because all Chinese/Dangi months have the same number of minimum resp.
maximum days per month.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37099145c6fb
https://hg.mozilla.org/integration/autoland/rev/669b3bf32072
Constrain day before calling CreateDateFromCodes with overflow=reject for Hebrew calendar. r=spidermonkey-reviewers,dminor

Comment 3

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/669b3bf32072