Closed Bug 2005490 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 56680 - Compute gradient values in image-set()

Tracking

()

Status:

RESOLVED FIXED

Milestone:

148 Branch

Tracking Flags:

Tracking

Status

firefox148

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

3 months ago

Sync web-platform-tests PR 56680 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/56680
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Compute gradient values in image-set()

Top level gradient values had values computed as necessary,
but not as gradients inside image-set() and cross-fade().

This CL implements resolution in CSSImageSetValue.

Bug: 466978530
Change-Id: Ib25ecaf2e78e5933081b2f72de7d74b0d00f5a3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7245973
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557295}

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

3 months ago

PR 56680 applied with additional changes from upstream: 63a6009a56d37ff82a9441d5c57f334795e6e97a, 80c17839b17bfca967b3acf2980a6da95b342535

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

3 months ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

3 months ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5b413efccc5e3fa637c335b7b55e454deee47fd

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

3 months ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 21 tests and 2 subtests

Status Summary

Firefox

OK : 1[GitHub] 21[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS : 16
FAIL : 3[GitHub] 74[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

CRASH: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-values/tree-counting/calc-sibling-function-in-shadow-dom.html [wpt.fyi]
- Host children have sibling-index() and sibling-count() based on the DOM tree order: FAIL
/css/css-values/tree-counting/calc-sibling-function-parsing.html [wpt.fyi]
- e.style['left'] = "calc(1px * sibling-index())" should set the property value: FAIL
- e.style['left'] = "calc(1px * sibling-index( ))" should set the property value: FAIL
- e.style['z-index'] = "sibling-index()" should set the property value: FAIL
- e.style['left'] = "calc(1px * sibling-count())" should set the property value: FAIL
- e.style['left'] = "calc(1px * sibling-count( ))" should set the property value: FAIL
- e.style['z-index'] = "sibling-count()" should set the property value: FAIL
/css/css-values/tree-counting/calc-sibling-function.html [wpt.fyi]
- basic sibling-index() test: FAIL
- basic sibling-count() test: FAIL
- sibling-index() in calc() with percentage: FAIL
- sibling-count() on pseudo-element: FAIL
- sibling-index() on root: FAIL
- sibling-count() on root: FAIL
/css/css-values/tree-counting/sibling-function-container-query-invalidation.html [wpt.fyi]
- sibling-index() in @container width query matching after removal: FAIL
- sibling-count() in @container width query matching after removal: FAIL
- sibling-index() in @container style() query matching after removal: FAIL
- sibling-count() in @container style() query matching after removal: FAIL
/css/css-values/tree-counting/sibling-function-container-query.html [wpt.fyi]
- sibling-index() in @container width query: FAIL
- sibling-count() in @container width query: FAIL
- sibling-index() in @container style() query: FAIL
- sibling-count() in @container style() query: FAIL
/css/css-values/tree-counting/sibling-function-descriptors.tentative.html [wpt.fyi]
- sibling-index() should not be allowed in @font-face descriptors: FAIL
- sibling-count() should not be allowed in @font-face descriptors: FAIL
- sibling-index() should not be allowed in @font-feature-values descriptors: FAIL
- sibling-count() should not be allowed in @font-feature-values descriptors: FAIL
/css/css-values/tree-counting/sibling-function-invalidation.html [wpt.fyi]
- Initially 6th sibling: FAIL
- 5th sibling after removal: FAIL
- Initially 6 siblings: FAIL
- 5 siblings after removal: FAIL
/css/css-values/tree-counting/sibling-index-keyframe-font-style-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-font-variation-settings-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-font-weight-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-length-value-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 2 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-palette-mix-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 4 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-percent-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-registered-properties-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for --time: FAIL
- Initially, the sibling-index() is 3 for --angle: FAIL
- Initially, the sibling-index() is 3 for --resolution: FAIL
- Initially, the sibling-index() is 3 for --percentage: FAIL
- Initially, the sibling-index() is 3 for --number: FAIL
- Initially, the sibling-index() is 3 for --integer: FAIL
- Initially, the sibling-index() is 3 for --length: FAIL
- Initially, the sibling-index() is 3 for --length-percentage: FAIL
- Initially, the sibling-index() is 3 for --color: FAIL
- Initially, the sibling-index() is 3 for --list: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --time: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --angle: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --resolution: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --percentage: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --number: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --integer: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --length: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --length-percentage: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --color: FAIL
- Removing a preceding sibling of #target reduces the sibling-index() for --list: FAIL
/css/css-values/tree-counting/sibling-index-keyframe-rotate-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-scale-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-transform-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-keyframe-value-dynamic.html [wpt.fyi]
- Initially, the sibling-index() is 3 for #target: FAIL
- Removing a preceding sibling of #target reduces the sibling-index(): FAIL
/css/css-values/tree-counting/sibling-index-linear-gradient-gcs.html [wpt.fyi]
- Check that sibling-index() is resolved in serialization of computed value of linear-gradient(): FAIL
- Check that sibling-index() is resolved in serialization of computed value of linear-gradient() inside cross-fade(): FAIL
- Check that sibling-index() is resolved in serialization of computed value of linear-gradient() inside image-set(): FAIL
/css/css-values/tree-counting/tree-scoped-sibling-function.html [wpt.fyi]
- sibling-index() and sibling-count() evaluates to 0 from outer tree with ::part: FAIL
- sibling-index() and sibling-count() evaluate as normal from inner tree: FAIL

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

3 months ago

Depends on: 2006140

Pulsebot

Comment 4

•

3 months ago

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/14accceecd46 https://hg.mozilla.org/integration/autoland/rev/0d37bf4aebd4 [wpt PR 56680] - Compute gradient values in image-set(), a=testonly https://github.com/mozilla-firefox/firefox/commit/91257e049e3d https://hg.mozilla.org/integration/autoland/rev/ce4a926e9af8 [wpt PR 56680] - Update wpt metadata, a=testonly

Cristian Tuns

Comment 5

•

3 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0d37bf4aebd4
https://hg.mozilla.org/mozilla-central/rev/ce4a926e9af8

Status: NEW → RESOLVED

Closed: 3 months ago

status-firefox148: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 148 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 56680 - Compute gradient values in image-set()

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Comment 1

Updated

Comment 2

Comment 3

CI Results

Status Summary

Firefox

Chrome

Links

Details

New Tests That Don't Pass

Updated

Comment 4

Comment 5