2005503 - Fix srcsrv mapping in PDB files

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Yannis Juglaret [:yannis]]

srctool.exe is a Microsoft tool to help identify which (or how many) files present in a PDB have a working mapping to a source server, the tool reports those as indexed.

Before bug 2000605 (reached with mozregression), I get approximately the following result for every build:

xul.pdb: 21023 source files are indexed - 2134 are not.
mozglue.pdb: 235 source files are indexed - 331 are not.
firefox.pdb: 278 source files are indexed - 441 are not.

After bug 2000605, I get approximately the following result for every build:

xul.pdb: 3065 source files are indexed - 20151 are not.
mozglue.pdb: 4 source files are indexed - 562 are not.
firefox.pdb: none of the 719 source files are indexed.

Presumably this is because the following lines don't match anything anymore in symbolstore.py:

                        elif filename.startswith("git:github.com/mozilla/firefox:"):
                            (vcs, repo, source_file, revision) = filename.split(":", 3)
                            sourceFileStream += sourcepath + "*FIREFOX_GITHUB_TARGET*"
                            sourceFileStream += source_file + "*" + revision + "\r\n"

I'll write a patch to get back to the previous results. I'll also write a follow-up bug to investigate what's going on with the files that were already unindexed.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2000605

Comment 2

[Yannis Juglaret [:yannis]]

Attachment: Bug 2005503 - Fix srcsrv mapping in PDB files. r=mstange

This patch fixes a mismatch caused by some part of the code still
referencing the previous Firefox repository when the other part was now
referencing the new one. We define and rely on constants to avoid such
occurrences in the future.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e7114bcf2815
https://hg.mozilla.org/integration/autoland/rev/c199d0410aaf
Fix srcsrv mapping in PDB files. r=mstange

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c199d0410aaf

Comment 5

[Yannis Juglaret [:yannis]]

I confirm that we are back to the previous situation in today's Nightly:

xul.pdb: 21213 source files are indexed - 2132 are not.
mozglue.pdb: 235 source files are indexed - 331 are not.
firefox.pdb: 279 source files are indexed - 440 are not.

I'll propose a beta uplift.

Comment 6

[Yannis Juglaret [:yannis]]

Attachment: Bug 2005503 - Fix srcsrv mapping in PDB files.

This patch fixes a mismatch caused by some part of the code still
referencing the previous Firefox repository when the other part was now
referencing the new one. We define and rely on constants to avoid such
occurrences in the future.

Original Revision: https://phabricator.services.mozilla.com/D275995

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: No impact on users. Easier crash analysis and debugging for developers: Visual Studio will be able to automatically retrieve our sources from github.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Only affects our debug symbols (PDB files), which are not present on users' computers. Verified in Nightly.
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e391cfc7ee75
https://hg.mozilla.org/releases/mozilla-beta/rev/fe0d2a77a9ae