2005526 - Fix position-area alignment for popovers (auto margins)

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect, P3)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 2005526. Fix position-area alignment for popovers (auto margins). r=dshin

Comment 2

[Jonathan Watt [:jwatt]]

Without this fix the auto margins end up centering the popover in the selected position-area grid, which means the popover can be positioned quite far from its popover target.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/71bbc300d9e0
https://hg.mozilla.org/integration/autoland/rev/f73c37b9a648
Fix position-area alignment for popovers (auto margins). r=firefox-style-system-reviewers,emilio

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/f73c37b9a648

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 9532387 [details]
Bug 2005526. Fix position-area alignment for popovers (auto margins). r=dshin

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Impacts Anchor Positioning of popovers, which is one of our main use cases.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Code change limited in impact to just a subset of anchor positioning use cases.
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9532387 [details]
Bug 2005526. Fix position-area alignment for popovers (auto margins). r=dshin

Approved for 147.0b4.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0d6a03da7eeaa64f9be69d97061e4bb58df24044