2005746 - The msi installer UAC screen does not refer to the launched installer

Status: VERIFIED FIXED

(Enterprise Products :: Firefox, defect)

Description

[Romain Testard [:RT]]

Attachment: 5b2f8caa-d6f7-4f11-bd81-2dbce026d0f3~1.jpg

A confusing file name is displayed on the UAC prompt that does not align with the file name of the installer used.

Comment 1

[Romain Testard [:RT]]

Chrome uses a custom string describing the Chrome product "Google Chrome Installer". Could we use a similar approach or is it a limitation of our MSI wrapper?

Comment 2

[BMO Github Automation]

Attachment: [mozilla/enterprise-firefox] Bug 2005746 - Set MSI package description so UAC prompt shows a proper name (#698)

Comment 3

[Josh Porter [:jporter]]

Alexandre mentioned that this should land in m-c. I found an existing bug that mentions the issue occuring in the signing process so I will look into that a bit more. My proposed fix may not be effective depending where the randomized filename occurs, I am not sure if it is also happening during signing or if the added description in MSI repackaging will filter through to the signing process.

Comment 4

[:gerard-majax]

(In reply to Josh Porter from comment #3)

Alexandre mentioned that this should land in m-c. I found an existing bug that mentions the issue occuring in the signing process so I will look into that a bit more. My proposed fix may not be effective depending where the randomized filename occurs, I am not sure if it is also happening during signing or if the added description in MSI repackaging will filter through to the signing process.

Let's see when your PR finishes, but if it works for us, it should work for bug 1861868 and you should definitively try to land that on m-c

Comment 5

[Josh Porter [:jporter]]

Attachment: msi-installer-fixed-description.png

I was able to get this working by injecting the name in the authenticode_comment during the repackage signing. The PR is updated to reflect this change. I've submitted a patch upstream as well, but using the string Firefox Installer instead.

Comment 6

[BMO Github Automation]

Attachment: [mozilla/enterprise-firefox] Bug 2005746 - Define msi.display-name in repackage-msi task for use in authenticode_comment (#723)

Comment 7

[Josh Porter [:jporter]]

The upstream patch has been updated to add a msi.display-name parameter in the repackage-msi task to allow the task to define the name used in the authenticode_comment. Once this is accepted, I'll just need to add a definition to the task yaml for firefox-enterprise. This has been tested in our enterprise taskcluster by forcing a shippable task run, and verified by downloading and running the installer on Windows after installing the fake CA used to sign.

Comment 8

[BMO Github Automation]

Attachment: [mozilla/enterprise-firefox] Bug 2005746 - Add authenticode_comment to MSI repackage signing artifacts (#752)

Comment 9

[BMO Github Automation]

Attachment: [mozilla/enterprise-firefox] Bug 2005746 - Add msi.display-name for Firefox Enterprise to repackage-msi task parameters (#753)

Comment 10

[BMO Github Automation]

Authored by https://github.com/jporter-dev
https://github.com/mozilla/enterprise-firefox/commit/138805ece048e3fba47256ad893e3cd72664b98e
[enterprise-main] Bug 2005746 - Add msi.display-name for Firefox Enterprise to repackage-msi task parameters

Authored by https://github.com/lissyx
https://github.com/mozilla/enterprise-firefox/commit/c63564da3f63b7d1e543149ad1b44a0d37250784
[enterprise-main] Merge pull request #753 from jporter-dev/enterprise-bug2005746-add-enterprise-display-name-for-repackage-msi

Comment 11

[Peter Magyari (Desktop QA)]

Verified fixed using Firefox Enterprise 152.0a1 (20260423172247) on Windows 10/11.
The UAC prompt properly aligns with the file name of the installer.