Closed Bug 200580 Opened 22 years ago Closed 12 years ago

Remove nsIDTD::ConvertEntityToUnicode

Categories

(Core :: DOM: HTML Parser, defect, P2)

Product:
Core
Component:
DOM: HTML Parser
Platform:
PowerPC
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.5alpha

People

(Reporter: alecf, Assigned: alecf)

Details

(Keywords: memory-footprint)

Attachments

(1 file)

part one, fix up nsIDTD
3.77 KB, patch
harishd
: review+
jst
: superreview+
Details | Diff | Splinter Review
The only consumers of nsHTMLEntities::EntityToUnicode and nsHTMLEntities::UnicodeToEntity are: nsIParserService, which is only used by content/base/src/nsPlaintextSerializer and content/base/src/nsHTMLContentSerializer nsIDTD, which isn't used by anyone the whole nsHTMLEntities.cpp file can be moved into content, and consumers can call that directly rather than going through nsIParserService
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.4alpha
Here's the first part, removing it from nsIDTD and those who implement it.
Comment on attachment 119387 [details] [diff] [review] part one, fix up nsIDTD harish/johnny - mind a quick review on this code removal?
Attachment #119387 - Flags: superreview?(jst)
Attachment #119387 - Flags: review?(harishd)
Target Milestone: mozilla1.4alpha → mozilla1.4beta
Comment on attachment 119387 [details] [diff] [review] part one, fix up nsIDTD sr=jst
Attachment #119387 - Flags: superreview?(jst) → superreview+
Comment on attachment 119387 [details] [diff] [review] part one, fix up nsIDTD r=harishd
Attachment #119387 - Flags: review?(harishd) → review+
Target Milestone: mozilla1.4beta → mozilla1.5alpha
QA Contact: dsirnapalli → parser
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: move nsHTMLEntities stuff into content → Remove nsIDTD::ConvertEntityToUnicode
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: