2006002 - Anchored popover does not follow element when scrolling viewport

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect)

Description

[[e-mail]]

See this example: https://codepen.io/mariusgundersen/pen/WbwPWVj

When the popover is opened it is correctly positioned above the button, but when the viewport is scrolled it stays locked to it's position relative to the viewport, not the element that is scrolled away.

Comment 1

[David Shin[:dshin]]

Ohkay.. That was confusing for a moment because with position: absolute, scrolling works - But that has to do with it parenting to scrolled content, where position: fixed parents to the viewport.
This is because we don't add implicit anchors to the scroll compensation mechanism, and since there are no explicit anchors, we don't run the scroll compensation machinery.

Comment 2

[David Shin[:dshin]]

Attachment: Bug 2006002: Ensure that positioned elements with implicit anchors get scroll compensated. r=#anchor-pos

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b0c7c803439
https://hg.mozilla.org/integration/autoland/rev/788e30c8bc93
Ensure that positioned elements with implicit anchors get scroll compensated. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56831 for changes under testing/web-platform/tests

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/330ab66d1042
https://hg.mozilla.org/integration/autoland/rev/27a3dd5dcaf0
Revert "Bug 2006002: Ensure that positioned elements with implicit anchors get scroll compensated. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio" for causing bc failures on browser_retainedResultsOnFocus.js

Comment 6

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on browser_retainedResultsOnFocus.js

Backout link

Push with failures

Failure log
Failure log
Failure log
Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/88a366abf78c
https://hg.mozilla.org/integration/autoland/rev/280695e1643b
Ensure that positioned elements with implicit anchors get scroll compensated. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/280695e1643b

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2006002: Ensure that positioned elements with implicit anchors get scroll compensated.

Original Revision: https://phabricator.services.mozilla.com/D276884

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/1a73a3b9ca69
https://hg.mozilla.org/releases/mozilla-release/rev/cc09b210795d