2006027 - sync-about-blank causes an unexpected, additional about:blank in session store

Status: NEW

(Core :: Session Restore, defect, P3)

Description

[Vincent Hilla [:vhilla]]

Attachment: session store state

Testcase

add_task(async function () {
  const tab = await BrowserTestUtils.openNewForegroundTab({ gBrowser, opening: "https://example.com", waitForLoad: true });
  await TabStateFlusher.flushWindow(window);
  let state = SessionStore.getCurrentState(true);
  SessionStore.keepOnlyWorthSavingTabs(state);
  dump(JSON.stringify(state) + "\n");
});

Expected: state should list one window with one tab for example.com
Actual: state contains one window with two tabs about:blank and example.com

Comment 1

[Vincent Hilla [:vhilla]]

I'm unsure if this is observable outside of browser tests.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 543435

Comment 3

[Andreas Farre [:farre]]

Vincent, S3 sound good?

Comment 4

[Vincent Hilla [:vhilla]]

Yes, maybe even S4.

I wasn't able to trigger this directly in the browser and am not aware of bugs being filed for about:blank being restored unexpectedly. As long as this only happens with BrowserTestUtils, it seems ok.

Comment 5

[Donal Meehan [:dmeehan]]

Next week is the final week of nightly for Fx148.

:vhilla, what is the current status of the investigation/priority here? Is this something you need to fix for Fx148?

Comment 6

[Vincent Hilla [:vhilla]]

As long as we don't see this happening in the wild, i.e. it only occurs with BrowserTestUtils, this is low priority.