2006040 - Find-in-page should scroll to revealed matches

Status: RESOLVED FIXED

(Core :: Find Backend, defect)

Description

[Jake Archibald [:jakea]]

Attachment: Bug demo

Observed on MacOS, but I assume other platforms are impacted.

When found text (eg via cmd-f) is revealed, as in it was inside a <div hidden="until-found"> or <details>, the page should be scrolled to the match. Right now Firefox appears to scroll only to the container.

Demo.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

(Probably we're not flushing layout between revealing and scrolling-to-match)

Comment 2

[Jan Jaeschke [:jjaschke]]

So, the spec says to queue a task and run the ancestor revealing algorithm.

We do that, and after that, we scroll the selection into view, which means that we scroll before we reveal.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

A potential one-liner fix could be to use Async scroll mode here, but that said, the MoveFocus looks also suspicious since we'd be moving focus to something that hasn't been revealed...

Comment 4

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 2006040, part 1: Scroll asynchronously after revealing hidden content in find-in-page. r=emilio!

Before this patch, the ancestor reveal algorithm would run asynchronously,
and therefore after the synchronous scroll attempt.
This breaks find-in-page for hidden=until-found / details elements.

This patch moves the scroll logic to run after the reveal has completed.

Comment 5

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 2006040, part 2 - Scroll asynchronously also for window.find(). r=emilio!

Same as part 1, but for window.find().

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b391bb8e0f50
https://hg.mozilla.org/integration/autoland/rev/2e7e018acd6b
part 1: Scroll asynchronously after revealing hidden content in find-in-page. r=emilio
https://github.com/mozilla-firefox/firefox/commit/e987524d3443
https://hg.mozilla.org/integration/autoland/rev/ec705b3ec0db
part 2 - Scroll asynchronously also for window.find(). r=emilio

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2e7e018acd6b
https://hg.mozilla.org/mozilla-central/rev/ec705b3ec0db

Comment 8

[Jake Archibald [:jakea]]

dev-doc-needed because I marked this as a partial implementation in https://github.com/mdn/browser-compat-data/pull/28672, so that needs updating once we know what version it's landing in.

Comment 9

[Hamish Willee]

FF148 MDN work can be tracked in https://github.com/mdn/content/issues/42751 (just the BCD updated)