2006066 - Credit cards autofill settings are not visible

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Balázs Meskó]

I have investigated this issue based on a SUMO user report. Previously the card autofill settings were available with Hungarian locale, now they are gone. Based on info found https://support.mozilla.org/en-US/kb/credit-card-autofill ("The credit card autofill feature is available to users in all countries starting with Firefox 135"), this is a regression.

Workaround: By editing about:config, I managed to get it back. When I added ",HU" to extensions.formautofill.addresses.supportedCountries, it reappeared again. This does not make a whole lot of sense, as if on anything, this should depend on the extensions.formautofill.creditCards.supportedCountries config instead. (This looks awfully similar to a copy-paste bug.)

But the real issue is that settings should be available by default. I've installed a fresh Nightly 148.0a1, and it's not there (the same happens in Beta and Release, so I'm filing the bug for 146).

Comment 1

[BugBot [:suhaib / :marco]]

:mtigley, since you are the author of the regressor, bug 1971626, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alin Ilea, Desktop Test Engineering]

Hi,

I am able to reproduce the issue and confirm the regression. Also the workaround described by the user is working.
As a note, the autofill is working if you already have a CC saved, you can autofill a payment form, even if the payment section is not displayed in settings. Also the Credit Card capture doorhanger is displayed upon manually submit a payment form and the user can save a CC, without the payment section being displayed in settings.

Thanks for the report!

Comment 3

[Micah [:mtigley] (she/her)]

Attachment: Bug 2006066 - Move payments and addresses sections into separate groupboxes. r=dimi!

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1971626

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1ebd20dd1cf0
https://hg.mozilla.org/integration/autoland/rev/4bfcee5d168e
Move payments and addresses sections into separate groupboxes. r=dimi,omc-reviewers,emcminn

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4bfcee5d168e

Comment 7

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mtigley, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox147 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Micah [:mtigley] (she/her)]

Alin would you be able to verify the fix in Nightly? Thank you!

Comment 9

[Alin Ilea, Desktop Test Engineering]

Sure, just verified the issue and it is fixed in Nightly 148.0a1 (2025-12-21). The payment methods section is displayed by default in settings and the CC autofill is working as expected, using the latest HU Nightly build. Also tried with other few locale builds that are not included in extensions.formautofill.addresses.supportedCountries and it also works ok there now.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #7)

The patch landed in nightly and beta is affected.
:mtigley, is this bug important enough to require an uplift?

Comment 11

[Micah [:mtigley] (she/her)]

Attachment: Bug 2006066 - Move payments and addresses sections into separate groupboxes.

Original Revision: https://phabricator.services.mozilla.com/D276687

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users will not be able to see the payment methods section in the Firefox settings page
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Fix has been verified by QA
• Risk associated with taking this patch: low
• Explanation of risk level: The code moves the payment and addresses sections into their own groupbox element. No logic has been modified
• String changes made/needed: No
• Is Android affected?: no

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/650f216efb29
https://hg.mozilla.org/releases/mozilla-beta/rev/4b9895880890

Comment 14

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in Beta 147.0b7. The payment methods section is displayed by default in settings and the CC autofill is working as expected, using the latest HU Nightly build.