2006529 - Weather forecast widget - Add new weather endpoints

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Reem Hamoui]

Grab data from the API to display a 5-hour weather forecast

Comment 1

[Reem Hamoui]

Attachment: Bug 2006529 - Add new Merino weather endpoints. r=#home-newtab-reviewers

Comment 3

[Maxx Crawford [:maxx]]

See companion patch to create the new endpoint: https://github.com/mozilla-services/merino-py/pull/1268

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0733e0698daa
https://hg.mozilla.org/integration/autoland/rev/5d5c1961d42a
Add new Merino weather endpoints. r=home-newtab-reviewers,nina-py

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5d5c1961d42a

Comment 6

[Serban Stanca [:SerbanS]]

Reverted this as requested by @mcrawford.

• Revert link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a788d1b9eb2d
https://hg.mozilla.org/integration/autoland/rev/6056a7ad056d
Add new Merino weather endpoints. r=home-newtab-reviewers,maxx,nina-py

Comment 8

[rperta]

Backed out for causing xpcshell related failures on test_merinoClient_weather.js
Backout link
Push with failures
Failure log(s)
Failure line:

TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/unit/test_merinoClient_weather.js | xpcshell return code: 0
Unexpected exception TypeError: merino.fetchWeather is not a function at /builds/worker/workspace/build/tests/xpcshell/tests/browser/components/urlbar/tests/quicksuggest/unit/test_merinoClient_weather.js:133
fetchWeather@/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/urlbar/tests/quicksuggest/unit/test_merinoClient_weather.js:133:18
_run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1876:22
_run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1876:38
run@/builds/worker/workspace/build/tests/xpcshell/head.js:898:9
_do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:245:6
_execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:664:5
@-e:1:1
09:55:18 ERROR -
TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/unit/test_weather.js

Comment 9

[rperta]

It also causes these failures:
Push with failures
Failure log(s)
Failure log(s)
Failure lines:

TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_selected_result.js | selected_result_weather - Uncaught exception in test - TypeError: merino.fetchWeather is not a function
TEST-EXPECTED-FAIL | browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_selected_result.js | changed preference: browser.urlbar.quickactions.timesShownOnboardingLabel
TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/browser/browser_weather.js | showLessFrequentlyCapReached_manySearches - Uncaught exception in test - TypeError: merino.fetchWeather is not a function
...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c438f8296a20
https://hg.mozilla.org/integration/autoland/rev/0a4091382807
Add new Merino weather endpoints. r=home-newtab-reviewers,maxx,nina-py

Comment 11

[rperta]

Backed out for casusing multiple weather related failures.
Backout link
Push with failures
Mochitests Failure log(s)
Xpcshell Failure log(s)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7abe81ec545
https://hg.mozilla.org/integration/autoland/rev/968f90034f58
Add new Merino weather endpoints. r=home-newtab-reviewers,nina-py

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/968f90034f58