2006606 - clean out nsIMsgProcessReport

Status: RESOLVED FIXED

(MailNews Core :: Backend, task)

Description

[Magnus Melin [:mkmelin]]

There is a heap of code around nsIMsgProcessReport which does very little.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 2006606 - part1 - clean out nsIMsgProcessReport. r=BenC

There was only one case where (the odd case of nntp+smtp) where anything mattered.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 2006606 - part2 - remove returnToComposeWindowQuestion. r=BenC

This was used only by displayReport(). But return value from that was not used for anything. So would not work.
The actual returning to compose window when needed does seeem to happen, but in other code paths and not with the question.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 2006606 - part3 - inline msgSendReport into MessageSend. r=BenC

"genericFailureExplanation" was dead code, those if clauses would never be reached for real.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9220a455fb12
part1 - clean out nsIMsgProcessReport. r=BenC
https://hg.mozilla.org/comm-central/rev/d8a12bf78c1c
part2 - remove returnToComposeWindowQuestion. r=BenC
https://hg.mozilla.org/comm-central/rev/4ac10fcb1e48
part3 - inline msgSendReport into MessageSend. r=BenC