2006673 - Use getFormatedString for message window titles

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, task)

Description

[Ian Neal]

At the moment we format the folder/newsgroup name and server part of the message window in a not very locale friendly way, we make assumptions what comes about what should be the start, middle and end. We should use a formatted string instead and let localisers decide the best order.

Comment 1

[Ian Neal]

Attachment: 2006673-message-titles-25324.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: message window titles not always localised well
Testing completed (on m-c, etc.): 2.53.24pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 2 removals, 2 additions

Requesting feedback from flod that this is the correct approach.

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 9533692 [details] [diff] [review]
2006673-message-titles-25324.patch

Not perfect since you are hardcoding the separator and spacing for macOS, but it's also something we started doing in Firefox to simplify the code.

Overall, it makes sense.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9533692 [details] [diff] [review]
2006673-message-titles-25324.patch

LGTM r/a+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/110cb23cae70
Use getFormatedString for message window titles. f=flod r=frg DONTBUILD

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/c9181e3fb4b4bceaf80fedd07d9b210b1c65f035
Use getFormatedString for message window titles. f=flod r=frg a=frg