2006756 - Autofill "Select address" UI shows up on all pages with email-address-fields, if you have any address saved that includes an email address

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Steps to reproduce

1. In Firefox for Android, add some autofillable address. (Go to Settings | Autofill | Manage addresses | Add address, and then be sure to type in at least a name, street-address, zip-code, and an email address which is the last available field.)
2. Visit some page that has an email address field (specifically a field with <input autocomplete="email">) -- the attached testcase, or the https://sso.mozilla.com login form.
3. Tap the email address field to focus it.

Expected behavior

If any autocomplete UI shows up, it should just include email address.

Actual behavior

The full "Select address" autocomplete UI shows up, with each entry including every field that the user has entered a value for in their saved addresses (street address, phone number, etc). The email address (the thing we might actually autocomplete here) is listed at the very end of each entry, making it not super useful.

Device information

• Firefox version: 148.0a1 2025-12-16
• Android device model: Pixel 6a
• Android OS version: 16

Any additional information?

I'm pretty sure this regressed in the last month or two. (Just now getting around to filing, but I've been noticing it for a few weeks at least).
This often shows up for me on web pages that are only asking for an email address, e.g. login forms or sign-up-for-our-email-list type forms. In those cases, it feels quite bizarre (and superficially feels like a privacy footgun) for Firefox to be offering me a list that's mostly full of my mailing-addresses and phone numbers to autocomplete into forms that are just asking for email address.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Here's a screencast showing that the "Select Address" UI shows up on sso.mozilla.com, as an example (and shows the complete address record ("abc, 124 happy way, happyville [...]") instead of just the relevant bit, i.e. the email address).

Comment 2

[Daniel Holbert [:dholbert]]

Note: after a bit more testing, I've found that the autofill UI only gets offered if my saved address includes some value for at least these fields: Name, Street Address, Zip Code, and Email Address.

Name & Street Address can be a single letter ("a"), zip code can be a single digit ("1"), and the email address can be e.g. a@a (we don't offer to autofill if I put less than that).

Comment 3

[Daniel Holbert [:dholbert]]

Here's the regression range for when this started showing up on e.g. my attached testcase and sso.mozilla.com (on Firefox for Android at least):

Newest known good nightly: 2025-12-03
Oldest known bad nightly: 2025-12-04
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=9336a9aece47&tochange=81ecdc1354ae

In that range, I suspect the relevant commit would be from bug 1930874:
https://hg-edge.mozilla.org/mozilla-central/rev/02809fa23688fd0307a26c11e0d440eb66cad14a
Bug 1930874, allow filling single fields when they have autocomplete attributes assigned, r=dimi,credential-management-reviewers

Hi Neil - could you take a look here? Based on that^ commit's commit message, perhaps showing-the-autofill-UI might be intentional here, but perhaps we should be showing a more restricted version of it (not showing all of the irrelevant fields with street-address/phone-number/etc. that aren't actually going to be autofilled on a site like the sso.mozilla.com login page)?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1930874

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1930874

:enndeakin, since you are the author of the regressor, bug 1930874, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[Neil Deakin]

Attachment: Bug 2006756, don't treat single email fields as being a valid formfill section as those are often going to be login forms, r=#credential-management-reviewers

Comment 7

[Donal Meehan [:dmeehan]]

Next week is RC week for Fx147.
:enndeakin, any concerns getting the patched reviewed and landed? Any concerns with risk for an uplift?

Comment 8

[Neil Deakin]

No concerns. You can also just back out bug 1930874.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d20174d0d0e9
https://hg.mozilla.org/integration/autoland/rev/eb811e7c86a9
don't treat single email fields as being a valid formfill section as those are often going to be login forms, r=credential-management-reviewers,dimi

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/eb811e7c86a9

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:enndeakin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox147 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Neil Deakin]

Attachment: Bug 2006756, don't treat single email fields as being a valid formfill section as those are often going to be login forms,

Original Revision: https://phabricator.services.mozilla.com/D277122

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Some username fields -- those that appear as single email fields -- for login forms will not show the correct autofill dropdown, so logging in is more difficult.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Try to show the autocomplete dropdown for the login field on sso.mozilla.com
• Risk associated with taking this patch: low
• Explanation of risk level: Reverting part of a change just for email fields.
• String changes made/needed: None
• Is Android affected?: no

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9535915 [details]
Bug 2006756, don't treat single email fields as being a valid formfill section as those are often going to be login forms,

147 is on Release now. Moving the request over.

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/6d6dcbacf343
https://hg.mozilla.org/releases/mozilla-release/rev/5fa0b593c616

Comment 16

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Screenshot_20260127-125811.png

This issue is verified as fixed on Firefox for Android 148 beta 7 and Firefox RC 147.0.2 using Google Pixel 10 Pro (Android 16) and Samsung S24 Ultra (Android 16). Confirming that the "Select address" prompt is no longer displayed when focusing the email field from https://sso.mozilla.com .