Closed
Bug 2006785
Opened 5 months ago
Closed 5 months ago
Update urlbar-persisted-search-terms-schema.json to not require includeParams
Categories
(Firefox :: Address Bar, task, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
148 Branch
People
(Reporter: jteow, Assigned: jteow)
References
Details
(Whiteboard: [sng])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-esr140+
|
Details | Review |
I'd like to make includeParams an optional property so that we can instead use excludeParams when no inclusion criteria is needed.
| Assignee | ||
Updated•5 months ago
|
Summary: Update /urlbar-persisted-search-terms-schema.json to not require includeParams → Update urlbar-persisted-search-terms-schema.json to not require includeParams
Updated•5 months ago
|
| Assignee | ||
Comment 1•5 months ago
|
||
Pushed by jteow@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/69623bd6652d
https://hg.mozilla.org/integration/autoland/rev/72070de65fb4
Update urlbar-persisted-search-terms-schema.json to not require includeParams - r=daisuke,urlbar-reviewers
Comment 3•5 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
Updated•5 months ago
|
QA Whiteboard: [search] [qa-triage-done-c148/b147]
Comment 4•1 month ago
|
||
firefox-esr140 Uplift Approval Request
- User impact if declined/Reason for urgency: Test-only, fixes a test failure.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: Test-only
- String changes made/needed?: None
- Is Android affected?: no
Attachment #9557500 -
Flags: approval-mozilla-esr140?
Comment 5•1 month ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D276940
Updated•1 month ago
|
status-firefox-esr140:
--- → fixed
Updated•1 month ago
|
Attachment #9557500 -
Flags: approval-mozilla-esr140? → approval-mozilla-esr140+
You need to log in
before you can comment on or make changes to this bug.
Description
•