2006871 - Add [[Phase]] slot in ModuleRequest Record

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

The TC39 proposals Defer Import Evaluation and Source Phase Import have some common change to the spec, like adding a [[Phase]] slot in ModuleRequest record, and pass phase to other module loading functions.

This bug will handle the common parts first.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 2006871 - Part 1: Remove CreateModuleRequest.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 2006871 - Part 2: Add [[Phase]] in ModuleRequestObject.

ModuleRequest fields change:
Defer Import Evaluation: https://tc39.es/proposal-defer-import-eval/#table-modulerequest-fields
Source Phase Import: https://tc39.es/proposal-source-phase-imports/#table-modulerequest-record-fields

Import Call:
Defer Import Evaluation: https://tc39.es/proposal-defer-import-eval/#sec-import-call-runtime-semantics-evaluation
Source Phase Import: https://tc39.es/proposal-source-phase-imports/#sec-import-call-runtime-semantics-evaluation

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 2006871 - Part 3: Pass ImportPhase to various module functions.

Defer Import Evaluation:

• FinishLoadingImportedModule : https://tc39.es/proposal-defer-import-eval/#sec-FinishLoadingImportedModule
• ContinueDynamicImport: https://tc39.es/proposal-defer-import-eval/#sec-ContinueDynamicImport

Source Phase Import:

• FinishLoadingImportedModule: https://tc39.es/proposal-source-phase-imports/#sec-FinishLoadingImportedModule
• ContinueModuleLoading: https://tc39.es/proposal-source-phase-imports/#sec-ContinueModuleLoading
• InnerModuleLinking: https://tc39.es/proposal-source-phase-imports/#sec-InnerModuleLinking
• InnerModuleEvaluation: https://tc39.es/proposal-source-phase-imports/#sec-innermoduleevaluation

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/386979b1d183
https://hg.mozilla.org/integration/autoland/rev/99f52b3c99f7
Part 1: Remove CreateModuleRequest. r=jonco
https://github.com/mozilla-firefox/firefox/commit/a278af2759c3
https://hg.mozilla.org/integration/autoland/rev/d22a8a2e0313
Part 2: Add [[Phase]] in ModuleRequestObject. r=jonco
https://github.com/mozilla-firefox/firefox/commit/6a1bf0a16809
https://hg.mozilla.org/integration/autoland/rev/baf46da461cc
Part 3: Pass ImportPhase to various module functions. r=jonco

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/99f52b3c99f7
https://hg.mozilla.org/mozilla-central/rev/d22a8a2e0313
https://hg.mozilla.org/mozilla-central/rev/baf46da461cc