2006890 - Lando "link existing assessment" dropdown a bit confusing for secure revisions

Status: NEW

(Conduit :: Lando, defect, P3)

Description

[:Gijs (he/him)]

When rebasing a security bug the conflict + moz-phab uplift flow is really quite good, but not immediately clear. "Link existing assessment" shows an entry for "no revision associated" (presumably because the uplift rebase/patch failed) and a timestamp, and "secure bug" (or something to that effect - I neglected to take a screenshot).

Can we be smarter about this? Presumably we are associating to the existing bug, displaying the bug number or the revision from the existing (non-uplifted) patch, and its description, would help with this.

If it matters, I ran into this with https://lando.moz.tools/D277005 .

Comment 1

[Connor Sheehan [:sheehan]]

After bug 2006659, we started exposing the ID of the assessment in the uplift request UI widget as well as in the linking dropdown, so hopefully that helps with identifying the correct assessment.

We also have the new form view from bug 2006101, and we have support for linking in moz-phab with bug 2006722, displayed in the resolution steps after bug 2006730. So devs should be using the "Link existing assessment" button less going forward.

That said, displaying the bug number in the dropdown would be a welcome improvement, for when using the dropdown is necessary. As a larger point, it would be nice to track the bug number more concretely in the uplift related models.

Comment 2

[Valentin Gosu [:valentin] {{PTO until Nov 1st}}]

Could we also include a link to Reuse Previous Assessment on the Create Uplift Assessment page?
I've manually copy-pasted the assessments for many uplift conflicts because I didn't know this workflow existed :)

Comment 3

[Connor Sheehan [:sheehan]]

(In reply to Valentin Gosu [:valentin] from comment #2)

Could we also include a link to Reuse Previous Assessment on the Create Uplift Assessment page?
I've manually copy-pasted the assessments for many uplift conflicts because I didn't know this workflow existed :)

This entire workflow is about to be refreshed in bug 2050949. Existing assessments for a given bug will be presented as a list of options, with "None of the above, create a new assessment" integrated into the form. This picker is presented on the "Create Uplift Assessment" page as well.

Just landed a few patches for this today, should be deployed early next week. Those patches might also resolve this bug, we can evaluate once the changes are live.