Closed
Bug 2007031
Opened 2 months ago
Closed 2 months ago
Update ModalOverlay component to use dialog element
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
149 Branch
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: rhamoui, Assigned: rhamoui)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•2 months ago
|
||
|
||
Updated•2 months ago
|
Assignee: nobody → rhamoui
Attachment #9534121 -
Attachment description: WIP: Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. → Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=#home-newtab-reviewers
Status: NEW → ASSIGNED
Pushed by rhamoui@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/b6323dc4976f
https://hg.mozilla.org/integration/autoland/rev/c66e8036f530
Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Pushed by ctuns@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c14367dcaf72
https://hg.mozilla.org/integration/autoland/rev/57a3136b8cab
Revert "Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py" for causing bc failures in browser_topsites_section.js
|
||
Comment 4•2 months ago
|
||
Backed out for causing bc failures
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/extensions/newtab/test/browser/browser_topsites_section.js | Uncaught exception in test bound topsites_add - at chrome://mochitests/content/browser/browser/extensions/newtab/test/browser/browser_topsites_section.js:149 - TypeError: can't access property "click", addBtn is null
Flags: needinfo?(rhamoui)
Pushed by rhamoui@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/361201a00848
https://hg.mozilla.org/integration/autoland/rev/cec79447d7c9
Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Pushed by smolnar@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/82ea5a2188f4
https://hg.mozilla.org/integration/autoland/rev/0d6ddf226438
Revert "Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py" for causing bc failures
|
||
Comment 7•2 months ago
|
||
Backed out for causing bc failures
Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/0d6ddf2264385f0a8a4cf1e9d14c251bcd7a50ac
Failure log -> TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/extensions/newtab
Pushed by rhamoui@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/69a93649dd7c
https://hg.mozilla.org/integration/autoland/rev/dd00dc156b81
Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Pushed by smolnar@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5bc42c38a75f
https://hg.mozilla.org/integration/autoland/rev/352930761b37
Revert "Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py" for causing node newtab failures
|
|
||
Comment 10•2 months ago
|
||
Backed out for causing node newtab failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/352930761b3728cfa0805b8485424340a7abe723
|
||
Comment 11•2 months ago
|
||
Pushed by rhamoui@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/2078d7f60b84
https://hg.mozilla.org/integration/autoland/rev/bccc8826bee5
Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
|
|
Assignee | |
Updated•2 months ago
|
Flags: needinfo?(rhamoui)
|
||
Comment 12•2 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
|
|
||
Comment 13•2 months ago
|
||
Pushed by chorotan@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/e1e63541d434
https://hg.mozilla.org/integration/autoland/rev/ca4ebcf0db11
Revert "Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py" on request for causing newtab failures
|
||
Comment 14•2 months ago
|
||
Backed out here: https://hg.mozilla.org/integration/autoland/rev/ca4ebcf0db11d6f5b3f0d8b959182ecfd6ce9277
Status: RESOLVED → REOPENED
status-firefox148:
fixed → ---
Flags: needinfo?(rhamoui)
Resolution: FIXED → ---
Target Milestone: 148 Branch → ---
|
|
||
Updated•2 months ago
|
Attachment #9534121 -
Attachment description: Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=#home-newtab-reviewers → Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
|
|
||
Comment 15•2 months ago
|
||
Pushed by rhamoui@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/07168e932080
https://hg.mozilla.org/integration/autoland/rev/308d8629db7c
Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
|
|
Assignee | |
Updated•2 months ago
|
Flags: needinfo?(rhamoui)
|
||
Comment 16•2 months ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 2 months ago → 2 months ago
status-firefox149:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
|
||
Updated•19 days ago
|
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in
before you can comment on or make changes to this bug.
Description
•