Closed Bug 2007031 Opened 1 month ago Closed 1 month ago

Update ModalOverlay component to use dialog element

Categories

(Firefox :: New Tab Page, enhancement)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
149 Branch
Tracking Flags:
Tracking Status
firefox149 --- fixed

People

(Reporter: rhamoui, Assigned: rhamoui)

References

Details

Attachments

(1 file)

Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → rhamoui
Attachment #9534121 - Attachment description: WIP: Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. → Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=#home-newtab-reviewers
Status: NEW → ASSIGNED
Pushed by rhamoui@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b6323dc4976f https://hg.mozilla.org/integration/autoland/rev/c66e8036f530 Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c14367dcaf72 https://hg.mozilla.org/integration/autoland/rev/57a3136b8cab Revert "Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py" for causing bc failures in browser_topsites_section.js

Backed out for causing bc failures

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/extensions/newtab/test/browser/browser_topsites_section.js | Uncaught exception in test bound topsites_add - at chrome://mochitests/content/browser/browser/extensions/newtab/test/browser/browser_topsites_section.js:149 - TypeError: can't access property "click", addBtn is null
Flags: needinfo?(rhamoui)
Pushed by rhamoui@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/361201a00848 https://hg.mozilla.org/integration/autoland/rev/cec79447d7c9 Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/82ea5a2188f4 https://hg.mozilla.org/integration/autoland/rev/0d6ddf226438 Revert "Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py" for causing bc failures
Pushed by rhamoui@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/69a93649dd7c https://hg.mozilla.org/integration/autoland/rev/dd00dc156b81 Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5bc42c38a75f https://hg.mozilla.org/integration/autoland/rev/352930761b37 Revert "Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py" for causing node newtab failures
Pushed by rhamoui@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2078d7f60b84 https://hg.mozilla.org/integration/autoland/rev/bccc8826bee5 Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Flags: needinfo?(rhamoui)

https://hg.mozilla.org/mozilla-central/rev/bccc8826bee5

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox148: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
Regressions: 2008770
Pushed by chorotan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e1e63541d434 https://hg.mozilla.org/integration/autoland/rev/ca4ebcf0db11 Revert "Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py" on request for causing newtab failures

Backed out here: https://hg.mozilla.org/integration/autoland/rev/ca4ebcf0db11d6f5b3f0d8b959182ecfd6ce9277

Status: RESOLVED → REOPENED
status-firefox148: fixed → ---
Flags: needinfo?(rhamoui)
Resolution: FIXED → ---
Target Milestone: 148 Branch → ---
Attachment #9534121 - Attachment description: Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=#home-newtab-reviewers → Bug 2007031 - Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Pushed by rhamoui@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/07168e932080 https://hg.mozilla.org/integration/autoland/rev/308d8629db7c Update ModalOverlay component to use native HTML dialog element. r=home-newtab-reviewers,nina-py
Flags: needinfo?(rhamoui)

https://hg.mozilla.org/mozilla-central/rev/308d8629db7c

Status: REOPENED → RESOLVED
Closed: 1 month ago → 1 month ago
status-firefox149: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: