2007126 - Disabling recent searches expands the new search bar with an empty line

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Petruta Horea [:phorea]]

Attachment: disabled recent searches

Found in

• Firefox Nightly 148.0a1 2025-12-18;

Affected versions

• Firefox Nightly 148.0a1;

Affected platforms

• Windows 11;
• Ubuntu 24;
• macOS 15;

Unaffected platforms

• N/A;

Preconditions

• Have the search bar added to the toolbar.

Steps to reproduce

1. Perform a few searches with default engine from address bar and search bar.
2. Focus search bar by clicking on it with an empty input and check that previous searches are shown in the search bar dropdown.
3. Go to about:preferences#search and disable "Show recent searches" option.
4. Focus empty search bar.

Expected result

• Recent searches are no longer displayed, search bar dropdown is not expanded.

Actual result

• Search bar panel expands with an empty line.
• Please note that this doesn't reproduce when the history items are removed using "Remove from history" option.
• Not reproducible on the address bar.

Regression range

• Not a regression.
• Not reproducible with the legacy search bar.

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 2007126 - Disable UrlbarProviderHeuristicFallback on empty searches. r?#urlbar-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bf4841e5a17c
https://hg.mozilla.org/integration/autoland/rev/6a528a479c33
Disable UrlbarProviderHeuristicFallback on empty searches. r=urlbar-reviewers,mak

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6a528a479c33

Comment 4

[Petruta Horea [:phorea]]

Verified as fixed using Nightly 148.0a1 2026-01-12, across platforms.

Comment 5

[Alex Finder]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bf4841e5a17c
https://hg.mozilla.org/integration/autoland/rev/6a528a479c33
Disable UrlbarProviderHeuristicFallback on empty searches.
r=urlbar-reviewers,mak

Perfherder has detected a mozperftest performance change from push 6a528a479c333170d6b3b06ac0c7dafd0e0adc09.

No action is required from the author; this comment is provided for informational purposes only.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
4%	browser_translations_perf_base.js post-gc-parent-process-memory-usage	linux1804-64-shippable		207.59 -> 200.20
3%	browser_translations_perf_basememory.js stabilized-parent-process-memory-usage	linux1804-64-shippable		211.17 -> 203.91
3%	browser_translations_perf_basememory.js peak-parent-process-memory-usage	linux1804-64-shippable		213.61 -> 206.69
3%	browser_translations_perf_base.js peak-parent-process-memory-usage	linux1804-64-shippable		214.53 -> 207.61
3%	browser_translations_perf_basememory.js post-gc-parent-process-memory-usage	linux1804-64-shippable		205.41 -> 199.60
...	...	...	...	...
2%	browser_translations_perf_basememory.js peak-parent-process-memory-usage	linux1804-64-shippable		212.28 -> 207.10

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.