2007150 - Implement application-level protocol negotation at WebTransport session start

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

From the spec: section 6.2 items 14, 15 and 32:

Let protocols be options’s protocols

If any of the values in protocols occur more than once, fail to match the requirements for elements that comprise the value of the negotiated application protocol as defined by the WebTransport protocol, or have an isomorphic encoded length of 0 or exceeding 512, throw a SyntaxError exception. [WEB-TRANSPORT-OVERVIEW] Section 3.1.

If protocols is not empty, set a structured field value with (WT-Available-Protocols, a structured header list whose members are the structured header string items in protocols in order) in request’s header list.

and later in To process a WebTransport fetch response, item 5:

Set transport.[[Protocol]] to either the string value of the negotiated application protocol if present, following [WEB-TRANSPORT-OVERVIEW] Section 3.1, or "" if not present.

and in WebTransportOptions:

protocols, of type sequence<DOMString>, defaulting to []

    An optionally provided array of application-level protocol names. Selecting a preferred application-protocol and communicating it to the client is optional for the server. Servers might reject the request if a suitable protocol was not provided.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007150: Add protocols option to WebTransportOptions - partial DOM-only impl r=#dom-core!

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007150: Get the negotiated protocol from neqo for WebTransport r=#necko-reviewers!

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007150: next step hooking up WebTransport sub-protocol support r=#dom-core!

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007150: renumber the WebTransport constructor steps to match the current spec r=jib!

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007150: Update wpts for WebTransport sub-protocol negotiation r=jib!

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007150: Hook up WebTransport sub-protocol negotiation r=#necko-reviewers!,#dom-core!

IPC Layer (PBackground.ipdl) - Added nsString[] aProtocols parameter to CreateWebTransportParent
DOM Layer (WebTransport.cpp) - Extracted protocols from JavaScript API options and passed them through IPC at WebTransport.cpp:260-269, 386-390
Parent Process (BackgroundParentImpl.h/cpp, WebTransportParent.h/cpp) - Updated to receive and forward protocols through the IPC chain
Network Layer (nsIWebTransport.idl, WebTransportSessionProxy.cpp) -
Added protocols parameter to AsyncConnectWithClient interface
Implemented code to format and send wt-available-protocols HTTP header in the correct format: "protocol1", "protocol2", "protocol3"

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/061cafdb376a
https://hg.mozilla.org/integration/autoland/rev/4e63d4f5ddb3
Add protocols option to WebTransportOptions - partial DOM-only impl r=webidl,saschanaz,necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/20658c62af8e
https://hg.mozilla.org/integration/autoland/rev/b27d9aeacffd
Get the negotiated protocol from neqo for WebTransport r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/9cc90dea3e01
https://hg.mozilla.org/integration/autoland/rev/dfe47a253102
Hook up WebTransport sub-protocol negotiation r=necko-reviewers,dom-core-reviewers,smaug,valentin,ipc-reviewers
https://github.com/mozilla-firefox/firefox/commit/679e60c8d317
https://hg.mozilla.org/integration/autoland/rev/37fe0e600501
next step hooking up WebTransport sub-protocol support r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/3b5a94722152
https://hg.mozilla.org/integration/autoland/rev/731b83856d16
Update wpts for WebTransport sub-protocol negotiation r=necko-reviewers,valentin

Comment 8

[rperta]

Backed out for causing build bustages
Backout link
Push with failures
Failure log(s)

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61598 for changes under testing/web-platform/tests

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9cddc6771da5
https://hg.mozilla.org/integration/autoland/rev/716fd77534a8
Add protocols option to WebTransportOptions - partial DOM-only impl r=webidl,saschanaz,necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/41285e82c18a
https://hg.mozilla.org/integration/autoland/rev/d13db66deb44
Get the negotiated protocol from neqo for WebTransport r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/b49b2937dd58
https://hg.mozilla.org/integration/autoland/rev/698d6499034d
Hook up WebTransport sub-protocol negotiation r=necko-reviewers,dom-core-reviewers,smaug,valentin,ipc-reviewers
https://github.com/mozilla-firefox/firefox/commit/3057bd81e41a
https://hg.mozilla.org/integration/autoland/rev/d7814c57d1f6
next step hooking up WebTransport sub-protocol support r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/3e5f11729ba2
https://hg.mozilla.org/integration/autoland/rev/81156b4bbe84
Update wpts for WebTransport sub-protocol negotiation r=necko-reviewers,valentin

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/716fd77534a8
https://hg.mozilla.org/mozilla-central/rev/d13db66deb44
https://hg.mozilla.org/mozilla-central/rev/698d6499034d
https://hg.mozilla.org/mozilla-central/rev/d7814c57d1f6
https://hg.mozilla.org/mozilla-central/rev/81156b4bbe84

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot