2007165 - Support SendGroup in WebTransport

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

Support SendGroups for WebTransport in WebTransportDatagramsWritable
See section 4.1 and section 8 (and elsewhere) in the spec, and createSendGroup()

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Implement WebTransportSendGroup interface r=#necko-reviewers!,saschanaz!

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: add createSendGroup to WebTransport r=#necko-reviewers!,saschanaz!

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Update WebTransportSendStreamOptions r=saschanaz!

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Add WPTs for WebTransport SendGroup r=jib!

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Add API hookup for neqo to create WebTransport send groups r=#necko-reviewers!

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Wire up Create SendGroup WebTransport support r=#necko-reviewers!,#dom-core!

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Attachment: WIP: Bug 2007165: Bandwidth wpt tests for sendgroup -- WIP r=jib!

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Hook up DOM WebTransport sendGroup support to necko & neqo implementation r=#necko-reviewers!,#dom-core!

Also cleans up sendOrder to be compliant with the current spec

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Use per-writable algorithm and fully connect sendGroup/sendOrder r=saschanaz!

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: make WebTransport sendGroup id creation synchronous in the child r=saschanaz!,#necko-reviewers!

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Hook up DOM WebTransport sendGroup support to necko & neqo implementation (early) r=#necko-reviewers!,#dom-core!,#webidl!

Pulled forward from D285403 so SendStream-level sendGroup works when
testing this earlier stack position; the WebTransportSendOptions
base-dictionary refactor from D285403 is deferred (D277252 introduces that
dictionary later) - sendGroup is added directly to
WebTransportSendStreamOptions instead.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8e9c58616a60
https://hg.mozilla.org/integration/autoland/rev/eba43eb01dee
Implement WebTransportSendGroup interface r=saschanaz,necko-reviewers,webidl,smaug,valentin
https://github.com/mozilla-firefox/firefox/commit/aba9ba21657e
https://hg.mozilla.org/integration/autoland/rev/fe6bc378538f
Add API hookup for neqo to create WebTransport send groups r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/ed9780c55df6
https://hg.mozilla.org/integration/autoland/rev/a4a185703db0
make WebTransport sendGroup id creation synchronous in the child r=saschanaz,necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/81711771c06a
https://hg.mozilla.org/integration/autoland/rev/55a832162580
Wire up Create SendGroup WebTransport support r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/24d67cd36bae
https://hg.mozilla.org/integration/autoland/rev/d7740c6e50d4
Add WPTs for WebTransport SendGroup r=jib
https://github.com/mozilla-firefox/firefox/commit/ae9004a4a2b2
https://hg.mozilla.org/integration/autoland/rev/ed990bd1c61b
Hook up DOM WebTransport sendGroup support to necko & neqo implementation (early) r=necko-reviewers,webidl,kershaw,tschuster
https://github.com/mozilla-firefox/firefox/commit/50cb89dbd315
https://hg.mozilla.org/integration/autoland/rev/df11cb4f12c3
Use per-writable algorithm and fully connect sendGroup/sendOrder r=saschanaz,necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/a2430492c3ba
https://hg.mozilla.org/integration/autoland/rev/ab8f1719e10d
Update WebTransportSendStreamOptions r=saschanaz,webidl

Comment 13

[rperta]

Backed out for causing build bustages
Backout link
Push with failures
Failure log(s)

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007165: Expose WebTransportSendGroup r=#dom-core!

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61597 for changes under testing/web-platform/tests

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cbd4a4287a05
https://hg.mozilla.org/integration/autoland/rev/52d8630d7383
Implement WebTransportSendGroup interface r=saschanaz,necko-reviewers,webidl,smaug,valentin
https://github.com/mozilla-firefox/firefox/commit/471b6f0ad196
https://hg.mozilla.org/integration/autoland/rev/892de02cbcae
Expose WebTransportSendGroup r=webidl,dom-worker-reviewers,emilio,edenchuang
https://github.com/mozilla-firefox/firefox/commit/6b2de5468bcc
https://hg.mozilla.org/integration/autoland/rev/eb6f445b668c
Add API hookup for neqo to create WebTransport send groups r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/832fa83d49dc
https://hg.mozilla.org/integration/autoland/rev/1e4085292d43
make WebTransport sendGroup id creation synchronous in the child r=saschanaz,necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/7cc8b75ecf28
https://hg.mozilla.org/integration/autoland/rev/cbde3cee74dd
Wire up Create SendGroup WebTransport support r=necko-reviewers,kershaw
https://github.com/mozilla-firefox/firefox/commit/abe0006d7ebc
https://hg.mozilla.org/integration/autoland/rev/bee330707687
Add WPTs for WebTransport SendGroup r=jib
https://github.com/mozilla-firefox/firefox/commit/cf9c3d3d1e4e
https://hg.mozilla.org/integration/autoland/rev/548a7ae2099f
Hook up DOM WebTransport sendGroup support to necko & neqo implementation (early) r=necko-reviewers,webidl,kershaw,tschuster
https://github.com/mozilla-firefox/firefox/commit/fedb8909e250
https://hg.mozilla.org/integration/autoland/rev/582f07c9c04a
Use per-writable algorithm and fully connect sendGroup/sendOrder r=saschanaz,necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/92612e741d35
https://hg.mozilla.org/integration/autoland/rev/0c7d7b93ff9c
Update WebTransportSendStreamOptions r=saschanaz,webidl

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/52d8630d7383
https://hg.mozilla.org/mozilla-central/rev/892de02cbcae
https://hg.mozilla.org/mozilla-central/rev/eb6f445b668c
https://hg.mozilla.org/mozilla-central/rev/1e4085292d43
https://hg.mozilla.org/mozilla-central/rev/cbde3cee74dd
https://hg.mozilla.org/mozilla-central/rev/bee330707687
https://hg.mozilla.org/mozilla-central/rev/548a7ae2099f
https://hg.mozilla.org/mozilla-central/rev/582f07c9c04a
https://hg.mozilla.org/mozilla-central/rev/0c7d7b93ff9c

Comment 19

[Hamish Willee]

FF155 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/45302