Closed Bug 2007200 Opened 7 months ago Closed 19 days ago

Support ExportKeyingMaterial for WebTransport

Tracking

()

Status:

RESOLVED FIXED

Milestone:

155 Branch

Tracking Flags:

Tracking

Status

firefox155

---

fixed

People

(Reporter: jesup, Assigned: jesup, NeedInfo)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged], [wptsync upstream])

Attachments

(7 files, 2 obsolete files)

Bug 2007200: Implement exportKeyingMaterial() method r=saschanaz! 7 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 2007200: Add wpt tests for WebTransport exportKeyingMaterial r=jib! 6 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 2007200: Add WebTransport ExportKeyingMaterial backend r=#necko-reviewers! 5 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 2007200: Hook up WebTransport exportKeyingMaterial to necko/neqo r=#necko-reviewers! 5 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 2007200: Update exportKeyingMaterial WPTs for spec change r=jib! 1 month ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
WIP: Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength 20 days ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength r=#webidl!,#necko-reviewers!,#dom-core! 20 days ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength r=#webidl!,#necko-reviewers!,#dom-core! 3 hours ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 2007200: reject ExportKeyingMaterial's promise on failure instead of resolving with an empty array r=#dom-core! 3 hours ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review

Randell Jesup [:jesup] (needinfo me)

Assignee

Description

•

7 months ago

See https://www.w3.org/TR/webtransport/#webtransport-methods

Randell Jesup [:jesup] (needinfo me)

Assignee

Updated

•

7 months ago

Depends on: 2007201

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 1

•

7 months ago

Attached file Bug 2007200: Implement exportKeyingMaterial() method r=saschanaz! — Details

Sunil Mayya

Updated

•

7 months ago

Severity: -- → N/A

Priority: -- → P2

Whiteboard: [necko-triaged]

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 2

•

6 months ago

Attached file Bug 2007200: Add wpt tests for WebTransport exportKeyingMaterial r=jib! — Details

Phabricator Automation

Updated

•

6 months ago

Assignee: nobody → rjesup

Status: NEW → ASSIGNED

Phabricator Automation

Updated

•

5 months ago

Attachment #9534319 - Attachment description: WIP: Bug 2007200: Implement exportKeyingMaterial() method r=#necko-reviewers!,#dom-reviewers! → Bug 2007200: Implement exportKeyingMaterial() method r=saschanaz!

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 3

•

5 months ago

Attached file Bug 2007200: Add WebTransport ExportKeyingMaterial backend r=#necko-reviewers! — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 4

•

5 months ago

Attached file Bug 2007200: Hook up WebTransport exportKeyingMaterial to necko/neqo r=#necko-reviewers! — Details

Phabricator Automation

Updated

•

5 months ago

Attachment #9534319 - Attachment description: Bug 2007200: Implement exportKeyingMaterial() method r=saschanaz! → WIP: Bug 2007200: Implement exportKeyingMaterial() method r=saschanaz!

Phabricator Automation

Updated

•

5 months ago

Attachment #9534319 - Attachment description: WIP: Bug 2007200: Implement exportKeyingMaterial() method r=saschanaz! → Bug 2007200: Implement exportKeyingMaterial() method r=saschanaz!

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 5

•

1 month ago

Attached file Bug 2007200: Update exportKeyingMaterial WPTs for spec change r=jib! — Details

Per w3c/webtransport#774, exportKeyingMaterial(label, context, outputLength)
takes all three arguments as required (context is no longer optional and the
prose no longer says "if context is given"). Implement outputLength end to end:
the DOM validates it (RangeError if 0 or > 4096) and plumbs it through IPC, the
necko nsIWebTransport interface, the Http3/Http2 sessions, and the neqo glue,
which now sizes the exporter output to outputLength instead of a hardcoded 32.

Rewrite the WPTs to the 3-argument form (asserting the output is outputLength
bytes, plus outputLength RangeError coverage) and drop the now-passing
idlharness exportKeyingMaterial expected-FAIL.

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 6

•

20 days ago

Attached file WIP: Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength (obsolete) — Details

Rewrite the WPTs to the 3-argument form (asserting the output is outputLength
bytes, plus outputLength RangeError coverage) and drop the now-passing
idlharness exportKeyingMaterial expected-FAIL.

Pulsebot

Comment 7

•

20 days ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f882f45e3103 https://hg.mozilla.org/integration/autoland/rev/ca41a57aa2b4 Implement exportKeyingMaterial() method r=saschanaz,webidl,tschuster,smaug https://github.com/mozilla-firefox/firefox/commit/7bcd930d5d79 https://hg.mozilla.org/integration/autoland/rev/f9427dfe054a Add WebTransport ExportKeyingMaterial backend r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/04e1ad930476 https://hg.mozilla.org/integration/autoland/rev/04122bc7f100 Hook up WebTransport exportKeyingMaterial to necko/neqo r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/a3d89ea678c8 https://hg.mozilla.org/integration/autoland/rev/dc7d8e0ce670 Add wpt tests for WebTransport exportKeyingMaterial r=jib https://github.com/mozilla-firefox/firefox/commit/352ec53c7d9c https://hg.mozilla.org/integration/autoland/rev/cb21b3eec5ef 2007206: apply code formatting via Lando

Pulsebot

Comment 8

•

20 days ago

Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/78a5278d9691 https://hg.mozilla.org/integration/autoland/rev/daa7a7b4892e Revert "Bug 2007200, 2007206: apply code formatting via Lando" for causing wpt lint failures & build bustages @ TestHttp3ConnectUDPStream.cpp

Sandor Molnar[:smolnar]

Comment 9

•

20 days ago

Backed out for causing wpt lint failures & build bustages @ TestHttp3ConnectUDPStream.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/daa7a7b4892e814fb53d8651a5e807db5d76d528

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/netwerk/test/gtest/TestHttp3ConnectUDPStream.cpp(31,7): error: abstract class is marked 'final' [-Werror,-Wabstract-final-class]

Failures log ->TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/tests/webtransport/export-keying-material.https.any.js:123 | Whitespace at EOL (TRAILING WHITESPACE)

Flags: needinfo?(rjesup)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Comment 10

•

20 days ago

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61501 for changes under testing/web-platform/tests

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Updated

•

20 days ago

Whiteboard: [necko-triaged] → [necko-triaged], [wptsync upstream]

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Comment 11

•

20 days ago

Upstream PR was closed without merging

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 12

•

20 days ago

Attached file Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength r=#webidl!,#necko-reviewers!,#dom-core! — Details

Phabricator Automation

Updated

•

20 days ago

Attachment #9615207 - Attachment is obsolete: true

Pulsebot

Comment 13

•

20 days ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d0fc4b94fb7e https://hg.mozilla.org/integration/autoland/rev/5e79b4fb08dd Implement exportKeyingMaterial() method r=saschanaz,webidl,tschuster,smaug https://github.com/mozilla-firefox/firefox/commit/65e72a996304 https://hg.mozilla.org/integration/autoland/rev/58159f5f6108 Add WebTransport ExportKeyingMaterial backend r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/451c5f579528 https://hg.mozilla.org/integration/autoland/rev/9f67d252dfde Hook up WebTransport exportKeyingMaterial to necko/neqo r=necko-reviewers,kershaw https://github.com/mozilla-firefox/firefox/commit/9d7262e33eb7 https://hg.mozilla.org/integration/autoland/rev/4b9f7380d121 Add wpt tests for WebTransport exportKeyingMaterial r=jib https://github.com/mozilla-firefox/firefox/commit/cff1d8b5320a https://hg.mozilla.org/integration/autoland/rev/4e2fc36feba8 apply code formatting via Lando

amarc

Comment 14

•

19 days ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/5e79b4fb08dd
https://hg.mozilla.org/mozilla-central/rev/58159f5f6108
https://hg.mozilla.org/mozilla-central/rev/9f67d252dfde
https://hg.mozilla.org/mozilla-central/rev/4b9f7380d121
https://hg.mozilla.org/mozilla-central/rev/4e2fc36feba8

Status: ASSIGNED → RESOLVED

Closed: 19 days ago

status-firefox155: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 155 Branch

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Comment 15

•

19 days ago

Upstream PR merged by moz-wptsync-bot

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Comment 16

•

19 days ago

Upstream PR merged

Phabricator Automation

Updated

•

18 days ago

Attachment #9615357 - Attachment description: WIP: Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength → Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength r=#necko-reviewers!,#webidl!,#dom-core!

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 17

•

3 hours ago

Attached file Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength r=#webidl!,#necko-reviewers!,#dom-core! (obsolete) — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 18

•

3 hours ago

Attached file Bug 2007200: reject ExportKeyingMaterial's promise on failure instead of resolving with an empty array r=#dom-core! — Details

Phabricator Automation

Updated

•

3 hours ago

Attachment #9626050 - Attachment is obsolete: true

Phabricator Automation

Updated

•

2 hours ago

Attachment #9615357 - Attachment description: Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength r=#necko-reviewers!,#webidl!,#dom-core! → Bug 2007200: make WebTransport exportKeyingMaterial args required and implement outputLength r=#webidl!,#necko-reviewers!,#dom-core!

You need to log in before you can comment on or make changes to this bug.