2007206 - Minor webidl interface updates for WebTransport update

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

WebTransportHash members are 'required'
correct createUnidirectionalStream return type

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007206: Correct WebTransport createUnidirectionalStream return type r=saschanaz!

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 2007206: Make WebTransportHash members required r=saschanaz!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b743e47619f9
https://hg.mozilla.org/integration/autoland/rev/feb614169416
Correct WebTransport createUnidirectionalStream return type r=webidl,smaug

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/feb614169416

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3c5fbcec3043
https://hg.mozilla.org/integration/autoland/rev/1415d0d0952f
Make WebTransportHash members required r=saschanaz,webidl

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/db4186c1a431
https://hg.mozilla.org/integration/autoland/rev/d4293f3c2459
Revert "Bug 2007206: Make WebTransportHash members required r=saschanaz,webidl" for causing wpt lint failures & build bustages @ TestHttp3ConnectUDPStream.cpp

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing wpt lint failures & build bustages @ TestHttp3ConnectUDPStream.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/d4293f3c24590d795f92964e2bd46a0cc1b2ca9f

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/netwerk/test/gtest/TestHttp3ConnectUDPStream.cpp(31,7): error: abstract class is marked 'final' [-Werror,-Wabstract-final-class]

Failures log ->TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/tests/webtransport/export-keying-material.https.any.js:123 | Whitespace at EOL (TRAILING WHITESPACE)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a1a9e3128b22
https://hg.mozilla.org/integration/autoland/rev/5491fd5e4c11
Make WebTransportHash members required r=saschanaz,webidl,necko-reviewers,kershaw

Comment 9

[rperta]

Backed out for causing build bustages
Backout link
Push with failures
Failure log(s)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22e400921107
https://hg.mozilla.org/integration/autoland/rev/666fca395229
Make WebTransportHash members required r=saschanaz,webidl,necko-reviewers,kershaw

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/666fca395229