2007274 - Drag and drop no longer works inside popup

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[juraj.masiar]

Attachment: drag_drop_broken.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:147.0) Gecko/20100101 Firefox/147.0

Steps to reproduce:

(see also attached video)

1. install Auto Highlight:
   https://addons.mozilla.org/addon/auto_highlight/
2. click the toolbar icon of the addon
3. click the "+" button in the left side (in the "Rules" section) to create two rules (they can be empty)
4. use drag and drop to reorder them

Actual results:

In Firefox 146, the drag and drop doesn't do anything.

Expected results:

In Firefox 145 the dragging works as expected (see video).

This is a regression in 146 version.
I've tried to run mozregression, but it failed with:

Error: Unable to exploit the merge commit. Origin branch is mozilla-central, and
the commit message for 69063d81 was:
Bug 1994157 - Partially revert the previous patch to land what emilio intended.

Comment 1

[Phil]

This issue has also been reported on the GitHub repository for "Simple Tab Groups".

In that issue we've had two people running Windows that have the problem described in this bugzilla ticket. I could not reproduce the problem - things work just fine on Arch Linux with Firefox 146.0.1 (and also already tested a few days ago with 146.0.0) using GNOME (Wayland).

Maybe this helps pin-point the issue.

Comment 2

[Alice0775 White]

Regression window:

https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=b37611e84ebb036d92146757e06277ef8d7db7f2&tochange=832b10027e3b1c44f0a22891903f657bf2a97064

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1933181, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

yeah this works on Linux for me too...

Comment 5

[Emilio Cobos Álvarez [:emilio]]

If someone is on mac, does it work there? Just trying to pin point as win-specific or not.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2007274 - Call EnableDragDrop on menupopups. r=tnikkel,#layout,#win-reviewers

This call used to happen before bug 1933181, via InitializeWindow(),
also right after widget creation time.

It seems to me all our widgets want d&d behavior, and Windows is the
only platform where we don't do that by default, for some reason... I'll
look into just removing this API in a follow-up bug, but for now this
one-liner restores behavior.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

ok, I think this is windows-specific. I think I have a fix but I can't test right now (it's from code inspection), so if someone can try a build from https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=170270 and confirm it fixes the issue it'd be awesome.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9534430 [details]
Bug 2007274 - Call EnableDragDrop on menupopups. r=tnikkel,#layout,#win-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Emilio Cobos Álvarez [:emilio]]

(I'll land the patch because at best is harmless :))

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0e7e9b8f9226
https://hg.mozilla.org/integration/autoland/rev/a7785ca5796d
Call EnableDragDrop on menupopups. r=tnikkel,layout-reviewers

Comment 11

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a7785ca5796d

Comment 12

[juraj.masiar]

I've tested it in yesterdays Nightly where the bug was present, and now I've retested it in today's Firefox Nightly 148.0a1 (2025-12-22) and the bug is gone.
Thank you for the quick fix, please uplift :)

Comment 13

[Ryan VanderMeulen (PTO, back 6-April)]

Comment on attachment 9534430 [details]
Bug 2007274 - Call EnableDragDrop on menupopups. r=tnikkel,#layout,#win-reviewers

Approved for 147.0b7.

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ef497d02109f
https://hg.mozilla.org/releases/mozilla-beta/rev/acfb5926f343

Comment 15

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (148.0a1/20251222211314) and Beta (147.0b7/20251222164020) under Windows 11.

I’ve also checked the latest Release (146.0.1/20251217121356) on Windows 11, macOS 11.3.1 and Ubuntu 24.10 for comparison. The issue occurs only on Windows. macOS and Ubuntu are not affected.

On Windows, rules can now be reordered by dragging and dropping, confirming the fix.

Comment 16

[Dianna Smith [:diannaS]]

Comment on attachment 9534430 [details]
Bug 2007274 - Call EnableDragDrop on menupopups. r=tnikkel,#layout,#win-reviewers

there are no more planned dot releases for 146.