Closed Bug 2007314 Opened 4 months ago Closed 1 month ago

Update urlbar-persisted-search-terms in Remote Settings for persisted search term

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

(Whiteboard: [sng])

To actually realize the persisted search term for Google and Bing, we need to update the urlbar-persisted-search-terms data in Remote Settings.
However, we should wait until the source is applied for the Release channel. Otherwise, it will break the persisted term for them from the beginning.
The fixing code in bug 1968218 is riding on the 148 train, it will appear on Feb 24th. We should update after the date.

Assignee: nobody → daisuke
Severity: -- → N/A
Priority: -- → P1
Whiteboard: [sng]

Cristian, is it possible to QA changes related to Persisted Search Daisuke put on Stage - Preview? The collection name is urlbar-persisted-search-terms

This will make it so that if you refine your search on Google or Bing using the search box on the page OR start your search on the home page, it will persist the search terms on the results page.

We want to make sure it works properly when it's the default and not the default (it will show the search mode tablet), and we don't persist the search terms when the user goes to other search verticals (e.g. Images, Maps, Shopping).

Flags: needinfo?(cbaica)

The issue is verified fixed using RS Stage-Preview and latest Fx 150.0a1, Fx 149.0b9 and Fx 148.0RC.

Persisted search term is correctly displayed for google and bing, when a search is refined from the search box, or a search is performed from the home page of google or bing. Search terms are not persisted when navigating to the other search verticals like Images, Maps or Shopping tab.

This is ready for PROD push from QA perspective.

Flags: needinfo?(cbaica)

Hi Cristian!
We deployed them to Prod too. Could you verify it?
If no problems, I want to close this bug. Thanks!

Flags: needinfo?(cbaica)

1968218#c9 hints that this RS update should touch on fixing DDG from RS side as well. However this issue and verification seems to touch only bing and google.

Flags: needinfo?(jteow)
Flags: needinfo?(daisuke)

(In reply to Adrian Florinescu [:aflorinescu] from comment #4)

1968218#c9 hints that this RS update should touch on fixing DDG from RS side as well. However this issue and verification seems to touch only bing and google.

My bad. So basically, Bing and Google now align to DDG behavior with the RS update, making bug 1968218 invalid.

Flags: needinfo?(jteow)
Flags: needinfo?(daisuke)

(In reply to Daisuke Akatsuka (:daisuke) from comment #3)

Hi Cristian!
We deployed them to Prod too. Could you verify it?
If no problems, I want to close this bug. Thanks!

Verified the RS update on 150.0a1 and Fx 148.0.2 using RS production with the expected results:

  • DDG, Bing, Google persist on urlbar + websearch refinement
  • DDG, Bing, Google do not persist on the other search verticals like Images, Maps or Shopping tab, etc where the full url will be displayed.

From QA perspective, the RS update is succesful and hence this issue can be closed.

Flags: needinfo?(cbaica) → needinfo?(daisuke)
QA Whiteboard: [qa-ver-done-c150/b149]

Thank you very much, Adrian!

Status: NEW → RESOLVED
Closed: 1 month ago
Flags: needinfo?(daisuke)
Resolution: --- → FIXED
Regressions: 2025933
You need to log in before you can comment on or make changes to this bug.