2007551 - Use swap-horizontal.svg in about:translations

Status: RESOLVED FIXED

(Firefox :: Translations, task, P3)

Description

[Erik Nordin [:nordzilla]]

Description

The about:translations page has long used arrows-updown.svg and transformed it into horizontal arrows for the swap-languages button.

Now that we are going to release the page officially, we should have an official swap-horizontal.svg icon.

I've requested the new icon here (internal only).

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 2007551 - Use new swap-horizontal-20.svg in about:translations r=#translations-reviewers!

This commit introduces the new official swap-horizontal-20.svg icon
and utilizes it in the about:translations page for the swap-languages
button.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f32b2adac212
https://hg.mozilla.org/integration/autoland/rev/03beb2a5a811
Use new swap-horizontal-20.svg in about:translations r=translations-reviewers,desktop-theme-reviewers,emilio,gregtatum

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9dd611698e23
https://hg.mozilla.org/integration/autoland/rev/7d1f99a91d5a
Revert "Bug 2007551 - Use new swap-horizontal-20.svg in about:translations r=translations-reviewers,desktop-theme-reviewers,emilio,gregtatum" for causing bc failures @ browser_MLSuggest_integration.js

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_MLSuggest_integration.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7d1f99a91d5ad7f18b36d2865563a16a8576ee12

Push with failures

Failure log -> browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js

Comment 5

[Erik Nordin [:nordzilla]]

This is part of a single backout that spanned multiple bugs.

In the patch stack, I increased the timeout when waiting for a mocked RemoteSettings model to download within our Translations tests, hoping that it might also help to reduce intermittent Translations test failures.

There are a few ml related tests that share our Remote Settings mocks. This test case happens to wait for the full duration of the timeout as part of the success path of the test case.

I've reverted the timeout change, and everything should hopefully be fine now.

I would one day like to either fully separate this code, or unify it in a way that ml doesn't rely on Translations under the hood, so that its more clear where the downstream consumers are.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5530b3be5c04
https://hg.mozilla.org/integration/autoland/rev/864bad3a56d7
Use new swap-horizontal-20.svg in about:translations r=translations-reviewers,desktop-theme-reviewers,emilio,gregtatum

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/864bad3a56d7