2007944 - browser_ext_browserAction_theme_icons.js fails when the system is using the dark theme

Status: NEW

(WebExtensions :: General, task)

Description

[Rob Wu [:robwu]]

The icon chosen for an extension button is dependent on the system's theme; by default a light theme is assumed (and the test is written with that assumption), but if the developer runs the test on a system with the dark theme enabled, then the test fails at https://searchfox.org/firefox-main/rev/b67c6262ecbe7d4c9385a1bd335fd7dd1d3f887d/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js#354-355,374-375

$ ./mach test browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js --headless
...
browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js
  FAIL Expected browser action icon (moz-extension://0f8c032e-7077-4f58-ae37-b9d1f9d68d68/white.png) to be black.png -
Stack trace:
chrome://mochikit/content/browser-test.js:test_ok:1775
chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js:testBrowserAction:31
chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js:browseraction_theme_icons_dynamic_theme:351
...
  FAIL Expected browser action icon (moz-extension://0f8c032e-7077-4f58-ae37-b9d1f9d68d68/white.png) to be black.png -
Stack trace:
chrome://mochikit/content/browser-test.js:test_ok:1775
chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js:testBrowserAction:31
chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js:browseraction_theme_icons_dynamic_theme:371
...

The above output is generated after the changes from bug 1994948; before that patch the error message was slightly different:

browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js
  FAIL Expected browser action icon (moz-extension://99144cee-757c-46d4-adc2-298c2b444ccd/light.png) to be default.png -
Stack trace:
chrome://mochikit/content/browser-test.js:test_ok:1759
chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js:testBrowserAction:27
chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js:browseraction_theme_icons_dynamic_theme:355
...
  FAIL Expected browser action icon (moz-extension://99144cee-757c-46d4-adc2-298c2b444ccd/light.png) to be default.png -
Stack trace:
chrome://mochikit/content/browser-test.js:test_ok:1759
chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js:testBrowserAction:27
chrome://mochitests/content/browser/browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js:browseraction_theme_icons_dynamic_theme:375
...

Comment 1

[Rob Wu [:robwu]]

The test passes if I force-disable dark theme with a preference:

./mach test browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js --headless --setpref=ui.systemUsesDarkTheme=0