Closed
Bug 200804
Opened 22 years ago
Closed 18 years ago
Autocomplete email addresses stops working at the @ symbol
Categories
(MailNews Core :: Composition, defect)
MailNews Core
Composition
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ham.mozilla.org, Assigned: Bienvenu)
References
Details
(Keywords: fixed1.8.1.1, regression)
Attachments
(1 file)
1.34 KB,
patch
|
neil
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
As per summary - autocomplete just goes away once you get to the @ symbol, even
though statistically this is the point where you MOST need it's help!
Even if you weren't going to autocomplete domain-names (which you definitely
should, see below for example reasons), it's still a bug that the autocomplete
dialog disappears, whilst many if not all of the different options are still valid!
Most people I know have email addresses of MYNAME@some-domain.com. Most English
people have short first-names. My address book (surely like most others?) is
full of entries like:
dave@mail.com
dave@organization.org
dave@simpsons.com
dave@daves-surname.com
ALL of which are different people. I know who's who by domain (and in some
cases, I ONLY know because of the domain - "Dave Washington" might not mean
anything to me, but "Dave from widgets-inc" would be the Dave who handles all
our dealings with Widgets inc.
Reproducible: Always
Steps to Reproduce:
1.Assuming you have front@domain.com in your address book, type in "front@"
2.
3.
Actual Results:
As soon as you hit "@", the autocomplete dialog disappears.
Expected Results:
Autcomplete dialog should remain, AND now filter out all addresses which don't
start "front@", since the name part of an email address typically is shared by
millions of people worldwide, and the uniqueness is the combination of "front"
and "domain.com".
Comment 2•22 years ago
|
||
*** This bug has been marked as a duplicate of 95631 ***
Status: UNCONFIRMED → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
Comment 3•22 years ago
|
||
Reopening. The other bug is talking about completion of domain for _unknown_
emails. This bug is about _known_ (present in address book) remains, and is a
regression....
Comment 4•22 years ago
|
||
If this is a regression, it broke before 20030307, so quite a long time ago.
Comment 5•22 years ago
|
||
I'm seeing this on 2003040308, someone please mark as "NEW"
Updated•22 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 6•22 years ago
|
||
It's not just a Linux problem. i also see this on Windows XP with build 2003041009.
Please set someone OS ALL. It is still a problem with Moz 1.7a 2004021508 WinNT4.
Comment 8•20 years ago
|
||
*** Bug 262216 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: MailNews → Core
Updated•20 years ago
|
Severity: normal → enhancement
OS: Linux → All
Hardware: PC → All
Updated•20 years ago
|
Severity: enhancement → normal
Comment 9•19 years ago
|
||
*** Bug 298940 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 10•18 years ago
|
||
Assignee: ducarroz → bienvenu
Status: NEW → ASSIGNED
Attachment #247473 -
Flags: superreview?(mscott)
Attachment #247473 -
Flags: review?(bugzilla)
Updated•18 years ago
|
Attachment #247473 -
Flags: superreview?(mscott) → superreview+
Comment 11•18 years ago
|
||
Comment on attachment 247473 [details] [diff] [review]
fix for local ab's
>- // strings with @ signs or commas (commas denote multiple names) should be ignored for
>+ // strings with commas (commas denote multiple names) should be ignored for
Interesting for two reasons:
a) the UI already splits addresses up at commas because (at least in Thunderbird) multiline pastes are translated to commas
b) What happens if my search string is "Foster, Aaron"?
Comment 12•18 years ago
|
||
Comment on attachment 247473 [details] [diff] [review]
fix for local ab's
Whilst this patch looks reasonable to me, I'm going to defer to Neil for review as he knows more about autocomplete than I do, and the possible implications of the changes (e.g. his comment 11)
Attachment #247473 -
Flags: review?(bugzilla) → review?(neil)
Comment 13•18 years ago
|
||
Comment on attachment 247473 [details] [diff] [review]
fix for local ab's
Well, this does what it says, although I'm still not convinced about commas.
I guess there's no strchr for PRUnichar* is there?
Attachment #247473 -
Flags: review?(neil) → review+
Assignee | ||
Comment 14•18 years ago
|
||
fixed on the 2.0 branch - no, there's no strchr for unicode strings in nspr...we could use an nsDependentString wrapper and use its Find method, I suppose.
Keywords: fixed1.8.1.1
Assignee | ||
Comment 15•18 years ago
|
||
fixed on trunk, for local ab case - ldap case is covered in bug 327263
Status: ASSIGNED → RESOLVED
Closed: 22 years ago → 18 years ago
Resolution: --- → FIXED
Comment 16•18 years ago
|
||
(In reply to comment #11)
> b) What happens if my search string is "Foster, Aaron"?
As soon as the comma is typed in, autocomplete stops matching. If I type "cowperthwaite" I get a matchlist with everyone in my family; add a comma to that and the field goes red (just checked this in TB2b1). That's the same behavior I see when I follow "mcow" (three matches) with an '@' (red). So I'll check this again with tomorrow's build and see what's different.
Assignee | ||
Comment 17•18 years ago
|
||
for QA, this change affects autocomplete against a local AB, from the compose window. It changes the behavior of autocomplete when the user starts typing an address and includes the '@'. That used to stop autocomplete; now, we still try to autocomplete against addresses with the '@'.
Comment 18•18 years ago
|
||
Working as advertised, TB 3a1-1206, Win2K. How nice that it could be done with such a small fix.
Status: RESOLVED → VERIFIED
Comment 19•18 years ago
|
||
my auto complete will lock up after typing one or two characters not at the @ symbol
Comment 20•18 years ago
|
||
I'm not seeing a lockup. Tony Evans, what platform are you running on? If you have extensions installed, do you still see the lockup after restarting in Safe Mode?
While retesting this, I notice this, which I should have noticed before:
I have two accounts, mcow@well.com and mcow@toast.net. The identity for the Well account has autocomplete-to-my-domain enabled.
If I open a compose window with that identity and type mcow@ I get three entried in the dropdown:
mcow@@well.com <- to my domain
mcow@toast.net
mcow@well.com
As I add characters, that @@ expands, e.g. mcow@toast@well.com. Obviously, once the @ has been typed, autocomplete-to-my-domain should stop appending another @ and if the @<substring> portion fails to match My Domain, that entry should be removed entirely.
Comment 21•18 years ago
|
||
mcow yes I have extensions, not many and have had some issues with some extensions but the ones I have seem to be stable enough. They are Contacts BCC, Diddlydo,display mail user agent, English Australian Dictionary, Lightning 0.3, mail redirect, minimise to tray, Mr Tech local install, reminder fox and talkback.
I am using Windows XP SP2.
With regards to my issue let me clarify. When I say TB locks up, what actually happens is as I type in the characters I can usually get one or two in lets say the email address is tegh@cosmic.com.au I can usually get as far as te then I can not do any more. If I try I get the TB is not responding message, if I wait for a couple of minutes I can continue typing. If I shut down TB and restart it I don't have the problem until it has been running for a while.
Hope this is of some help.
Comment 22•18 years ago
|
||
(In reply to comment #21)
> With regards to my issue let me clarify. When I say TB locks up, what actually
> happens is as I type in the characters I can usually get one or two in lets say
> the email address is tegh@cosmic.com.au I can usually get as far as te then I
> can not do any more. If I try I get the TB is not responding message, if I
> wait for a couple of minutes I can continue typing. If I shut down TB and
> restart it I don't have the problem until it has been running for a while.
Try following the instructions here: http://kb.mozillazine.org/Long_time_to_open_address_book
Comment 23•18 years ago
|
||
(In reply to comment #20)
> While retesting this, I notice this, which I should have noticed before:
I've opened bug 363094 for this issue.
Tony Evans: just because a bug has a word in common with your problem does not mean it's the same problem. If you weren't seeing your symptom as a result of typing the '@' sign, your comment did not belong here.
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•