2008127 - Button does not programmatically indicate that it opens a dialog (Customize button)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[John Northup]

Steps to Reproduce

Open DevTools. Inspect the Customize button.

Expected Behavior

aria-haspopup="dialog" is present.

Actual Behavior

aria-haspopup attribute not present.

User Impact

Semantic information diluted.

WCAG 2.2 References

Best practice only. While aria-haspopup="dialog" adds semantic information, its absence does not constitute a WCAG failure provided the dialog itself is properly implemented and announced.

Recommendations

Apply aria-haspopup="dialog" to the button that opens the dialog.

Testing Environment

Any

Assistive Technology Used

Any

Code Pointers

<button class="personalize-button personalize-animate-enter-done" data-l10n-id="newtab-customize-panel-icon-button" title="Customize this page">

Further Reference

• W3C WAI APG: Modal Dialog Example

Comment 1

[John Northup]

Attachment: Customize button with pencil icon

Comment 2

[Dana Lucaci, Desktop QA]

Reproduced with Firefox 148.0a1 (2025-12-31) on macOS 15 and Windows 10.
Marking this issue as new for engineering input.
Thank you!

Comment 3

[baris]

Hi, I'm a new contributor and I'd like to work on this bug. I've set up my development environment and can build Firefox locally. I'll add aria-haspopup="dialog" to the Customize button in CustomizeMenu.jsx.

Comment 4

[baris]

Attachment: Bug 2008127 - Add aria-haspopup="dialog" to Customize button on New Tab Page.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bc759a6f8a71
https://hg.mozilla.org/integration/autoland/rev/6c0b6b3b20de
Add aria-haspopup="dialog" to Customize button on New Tab Page. r=home-newtab-reviewers,reemhamz

Comment 6

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/6c0b6b3b20de