2008134 - Button does not programmatically indicate that it opens a dialog (Top sites/Shorctuts section > ••• disclosure > Add Shortcut link)

Status: NEW

(Firefox :: New Tab Page, enhancement)

Description

[John Northup]

Steps to Reproduce

Open DevTools. In the Top Sites/Shortcuts section, inspect the Add Shortcut link.

Expected Behavior

aria-haspopup="dialog" is present.

Actual Behavior

aria-haspopup attribute not present.

User Impact

Semantic information diluted.

WCAG 2.2 References

Best practice only. While aria-haspopup="dialog" adds semantic information, its absence does not constitute a WCAG failure provided the dialog itself is properly implemented and announced.

Recommendations

Apply aria-haspopup="dialog" to the button that opens the dialog.

Testing Environment

Any

Assistive Technology Used

Any

Code Pointers

<a class="top-site-button" tabindex="-1" draggable="true" data-is-sponsored-link="false" aria-label="Add Shortcut" data-l10n-id="newtab-topsites-add-shortcut-title" data-l10n-args="{&quot;title&quot;:&quot;&quot;}" title="Add Shortcut">
  <div class="tile" aria-hidden="true">
    <div class="icon-wrapper">
      <div class=""></div>
    </div>
  </div>
  <div class="title">
    <span class="title-label" dir="auto" data-l10n-id="newtab-topsites-add-shortcut-label">Add Shortcut</span>
    <span class="sponsored-label" data-l10n-id="newtab-topsite-sponsored">Sponsored</span>
  </div>
</a>

Further Reference

• W3C WAI APG: Modal Dialog Example

Comment 1

[John Northup]

Attachment: Add Shortcut link

Comment 2

[Dana Lucaci, Desktop QA]

Reproduced with Firefox 148.0a1 (2025-12-31) on macOS 15 and Windows 10.
Marking this issue as new for engineering input.
Thank you!