Ignore `core::result::unwrap_failed` in crash reporting signatures
Categories
(Socorro :: Signature, enhancement, P1)
Tracking
(Not tracked)
People
(Reporter: ErichDonGubler, Assigned: ErichDonGubler)
References
Details
Attachments
(1 file)
I discovered that, in some crash reports, Rust's core::result::unwrap_failed helper in its standard library is being reported as the signature frame. Unfortunately, this is a noisy frame that doesn't offer any diagnostic value, much like other unwrapping and panic internals already listed in socorro/signature/siglists/irrelevant_signature_re.txt.
Examples of some crash reports that his hampers:
| Assignee | ||
Comment 1•4 months ago
•
|
||
Discovered in crash reports like these: https://crash-stats.mozilla.org/search/?signature=~core%3A%3Aresult%3A%3Aunwrap_failed&date=%3E%3D2026-01-20T22%3A39%3A00.000Z&date=%3C2026-01-27T22%3A39%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature
Comment 2•3 months ago
|
||
Updated•3 months ago
|
Updated•3 months ago
|
| Assignee | ||
Comment 3•3 months ago
|
||
I apparently had tangentially related (but unclear) link pasted into comment 1! I've edited it so that it actually points to something interesting. 😅
Comment 4•3 months ago
|
||
Comment 5•2 months ago
|
||
This was deployed to production in https://github.com/mozilla-services/socorro/releases/tag/v2026.02.04.
Description
•