2008658 - Messages array in Chat.sys.mjs is incorrect

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, defect)

Description

[:omarg]

• Fix missing role values in assistant messages passed in ChatConversation.getMessagesInOpenAiFormat()
• Remove previously injected messages and recalculate on each submission
• Fix tool_calls key to the correct level

Comment 1

[:omarg]

Attachment: Bug 2008658 - fixes messages array for OpenAI api format r=tzhang,ai-frontend-reviewers,ai-models-reviewers

Comment 2

[:omarg]

Attachment: Bug 2008658 - fixes messages array for OpenAI api format r=tzhang,bjohns

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a7adf02cc574
https://hg.mozilla.org/integration/autoland/rev/8a7bad82af50
fixes messages array for OpenAI api format r=tzhang,ai-frontend-reviewers,ai-models-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3dc471cd51b1
https://hg.mozilla.org/integration/autoland/rev/dcbd28585876
Revert "Bug 2008658 - fixes messages array for OpenAI api format r=tzhang,ai-frontend-reviewers,ai-models-reviewers" for causing xpc failures @ test_Tools_GetOpenTabs.js

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_Tools_GetOpenTabs.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/dcbd28585876bb16095af8ff387e8649ed29c9dd

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/aiwindow/models/tests/xpcshell/test_Tools_GetOpenTabs.js

Comment 6

[:omarg]

I am commenting out the failed assertions and noting the changes in Bug 2009194 where the issue for these failures is being fixed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f30a4105039d
https://hg.mozilla.org/integration/autoland/rev/bd13b8fd9287
fixes messages array for OpenAI api format r=tzhang,ai-frontend-reviewers,ai-models-reviewers

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bd13b8fd9287

Comment 9

[:omarg]

Attachment: Bug 2008658 - fix messages for OpenAI api format, landing reattempt

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/812f1e64abee
https://hg.mozilla.org/integration/autoland/rev/12cc1fae1fd7
fix messages for OpenAI api format, landing reattempt r=ai-frontend-reviewers,Gijs

Comment 12

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/12cc1fae1fd7