2008744 - Make full JSON serialized WebAuthn request available to WebAuthn services

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, enhancement, P2)

Description

[John Schanck [:jschanck]]

We call platform WebAuthn APIs after deserializing the request and passing it over IPC, which means we need to map our internal representation of the request to each platform's representation. This is tedious and it slows the deployment of new features (e.g. Bug 1958716).

Some platform APIs, notably androidx.credentials, can take the JSON encoded request directly as input. We should make use of this when possible.

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 2008744 - pass JSON serialized WebAuthn requests to WebAuthnCredentialManager. r=keeler!,m_kato

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/caede9af7674
https://hg.mozilla.org/integration/autoland/rev/a0adbefe0865
pass JSON serialized WebAuthn requests to WebAuthnCredentialManager. r=m_kato,keeler,geckoview-reviewers,webidl,edgar,smaug

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9730bd9d032b
https://hg.mozilla.org/integration/autoland/rev/a5e90f5a36c9
Revert "Bug 2008744 - pass JSON serialized WebAuthn requests to WebAuthnCredentialManager. r=m_kato,keeler,geckoview-reviewers,webidl,edgar,smaug" for causing bustages @ WebAuthnHandler.cpp

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing bustages @ WebAuthnHandler.cpp

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6db81dd78705
https://hg.mozilla.org/integration/autoland/rev/a00af42b49de
pass JSON serialized WebAuthn requests to WebAuthnCredentialManager. r=m_kato,keeler,geckoview-reviewers,webidl,edgar,smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6041a25bd585
https://hg.mozilla.org/integration/autoland/rev/0ce3b0f31601
Revert "Bug 2008744 - pass JSON serialized WebAuthn requests to WebAuthnCredentialManager. r=m_kato,keeler,geckoview-reviewers,webidl,edgar,smaug" for causing hazard bustages at TestWebAuthnSerialization.cpp.

Comment 7

[Atila Butkovits]

Backed out for causing hazard bustages at TestWebAuthnSerialization.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0ce3b0f31601

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a00af42b49de9ff8c94f1baacb3d83a0abcac182&selectedTaskRun=Wp_aJ9UzRCaY3UAKvj6NAA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=545047369&repo=autoland&task=Wp_aJ9UzRCaY3UAKvj6NAA.0&lineNumber=104491

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22371ef633e4
https://hg.mozilla.org/integration/autoland/rev/1a85317b348f
pass JSON serialized WebAuthn requests to WebAuthnCredentialManager. r=m_kato,keeler,geckoview-reviewers,webidl,edgar,smaug

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1a85317b348f